feat(ios): expose new iOS 14 APIs in Ti.UI.WebView #11834

vijaysingh-axway · 2020-07-22T01:37:20Z

https://jira.appcelerator.org/browse/TIMOB-27987

build · 2020-07-22T01:39:58Z

	Messages
📖	✊ The commits in this PR match our conventions! Feel free to Rebase and Merge this PR when ready.
📖	✅ All tests are passing Nice one! All 5045 tests are passing. (There are 472 skipped tests not included in that total)

Generated by 🚫 dangerJS against a80e6e9

sgtcoolguy · 2020-07-28T18:57:12Z

@vijaysingh-axway formatting is bad for iOS code

apidoc/Titanium/UI/WebView.yml

sgtcoolguy · 2020-08-17T17:18:09Z

tests/Resources/ti.ui.webview.test.js

+		});
+
+		webView.addEventListener('load', function () {
+			webView.findString('google', function (e) {


add another test with the search options passed in? (i.e. case sensitive and search by bad case). Test "negative" case: search for something you know you won't find.

Also, this API leaves a bit to be desired. The options for wrapping/searching backwards don't seem very useful if we only get a boolean whether the search was found (rather than say also a position or something). But maybe it matters because it updates some UI state to highlight the result(s)?

In API doc, it is mentioned that "A match found by the search is selected and the page is scrolled to reveal the selection. The completion handler is called after the search completes". But it doesn't scroll and highlight in native as well. Probably beta issue.

tests/Resources/ti.ui.webview.test.js

sgtcoolguy

Again, my suggestions are not required - and are mainly around docs. I think this would benefit from a. couple examples and then perhaps a unit test that actually did what the proposed Web Archive example showed: saving to a web archive and then loading that in the web view.

Also, consistency around the callback object response by "extending" ErrorResponse in the docs and using the code internally that would make that reality (TiUtils dictionaryWithCode:)

sgtcoolguy · 2020-08-27T13:07:04Z

apidoc/Titanium/UI/WebView.yml

@@ -1114,6 +1156,67 @@ properties:
    description: May be undefined.
    type: String

+---
+name: DataCreationResult
+summary: The parameter passed to the <Titanium.UI.WebView.createPDF> or <Titanium.UI.WebView.createWebArchive>callback.


Suggested change

summary: The parameter passed to the <Titanium.UI.WebView.createPDF> or <Titanium.UI.WebView.createWebArchive>callback.

summary: The parameter passed to the <Titanium.UI.WebView.createPDF> or <Titanium.UI.WebView.createWebArchive> callback.

sgtcoolguy · 2020-08-27T13:08:15Z

apidoc/Titanium/UI/WebView.yml

+    summary: |
+        Create a PDF document representation from the web page currently displayed in the WebView.
+    description: |
+        If the data is written to a file the resulting file is a valid PDF document.


We may want to include an example in the docs showing how to call this method and then write the blob to a file in the callback.

sgtcoolguy · 2020-08-27T13:09:49Z

apidoc/Titanium/UI/WebView.yml

@@ -1114,6 +1156,67 @@ properties:
    description: May be undefined.
    type: String

+---
+name: DataCreationResult


Extend ErrorResponse? (I guess we don't set a code property, though?)

May make more sense to align this consistently, though, by doing so.

sgtcoolguy · 2020-08-27T13:11:43Z

iphone/Classes/TiUIWebViewProxy.m

-    @"minimumFontSize" : NUMFLOAT([[[[[self webView] webView] configuration] preferences] minimumFontSize]),
-    @"javaScriptEnabled" : NUMBOOL([[[[[self webView] webView] configuration] preferences] javaScriptEnabled]),
-    @"javaScriptCanOpenWindowsAutomatically" : NUMBOOL([[[[[self webView] webView] configuration] preferences] javaScriptCanOpenWindowsAutomatically]),
+    @"minimumFontSize" : NUMFLOAT([[[[self wkWebView] configuration] preferences] minimumFontSize]),


All these brackets in all these changes scream out to me to open this in Xcode and use dot notation if possible, i.e.:

Suggested change

@"minimumFontSize" : NUMFLOAT([[[[self wkWebView] configuration] preferences] minimumFontSize]),

@"minimumFontSize" : NUMFLOAT(self.wkWebView.configuration.preferences.minimumFontSize),

Just looks less messy to my eye and easier to follow. Not required (and possibly, not possible!)

sgtcoolguy · 2020-08-27T13:14:46Z

iphone/Classes/TiUIWebViewProxy.m

+  ENSURE_TYPE(callback, KrollCallback);
+
+  if (![TiUtils isIOSVersionOrGreater:@"14.0"]) {
+    [callback call:@[ @{ @"success" : NUMBOOL(NO), @"error" : @"Supported on iOS 14+" } ] thisObject:self];


As mentioned in the docs, probably want to use the [TiUtils dictionaryWithCode:] for all these callback args (here, and the code below) so we are consistent about the shape of our callback response objects.

sgtcoolguy · 2020-08-27T13:24:51Z

apidoc/Titanium/UI/WebView.yml

+  - name: createWebArchive
+    summary: Create WebKit web archive data representing the current web content of the WebView.
+    description: |
+        WebKit web archive data represents a snapshot of web content. It can be loaded into a WebView directly, 


It's unclear to me from the apple docs or looking at our code exactly how this would be used to load into a web view.

Presumably we can save this to a file, great - but how do we then load the file or blob and set it in a web view later? Can we simply provide the Ti.Filesystem.File or Ti.Blob we received as the Ti.UI.WebView.data property and it magically works? If so, perhaps we can provide an example in the docs here and add a unit test which does so?

ssjsamir

@vijaysingh-axway When testing the following test case:

var win = Ti.UI.createWindow({

backgroundColor: '#fff'
});
 
var nextWin = Ti.UI.createWindow({
backgroundColor: '#fff'
});
 
var closeButton = Ti.UI.createButton({
top: 50,
title: 'Close'
});
 
closeButton.addEventListener('click', function() {
nextWin.close();
});
 
nextWin.add(closeButton);
 
var nextWebView = Ti.UI.createWebView({
top: 100,
});
 
nextWin.add(nextWebView);
 
 
var btn1 = Ti.UI.createButton({
top: 50,
left: 20,
title: 'Search String (Measure)'
});
 
btn1.addEventListener('click',  function() {
webView.findString('Measure', function(e){ // {'caseSensitive': true, 'backward': false, 'wraps': true},
if (e.success) {
alert('Searched string found!');
} else {
alert('Searched string not found!');
}
});
});
 
win.add(btn1);
 
var btn2 = Ti.UI.createButton({
top: 50,
right: 20,
title: 'Create PDF of webpage'
});
 
btn2.addEventListener('click', function() {
webView.createPdf( function(e) {
nextWebView.data = e.data;
nextWin.open();
});
});
 
win.add(btn2);
 
var btn3 = Ti.UI.createButton({
top: 100,
left: 20,
title: 'Create Web Archive of page'
});
 
btn3.addEventListener('click', function() {
webView.createWebArchive(function(e){
nextWebView.data = e.data;
nextWin.open();
});
});
 
win.add(btn3);
 
var btn4 = Ti.UI.createButton({
top: 100,
right: 20,
title: 'Zoom by factor 2'
});
 
btn4.addEventListener('click', function() {
Ti.API.info('zoom level is ', +webView.zoomLevel);
webView.zoomLevel = 2;
Ti.API.info('zoom level is ', +webView.zoomLevel);
});
 
win.add(btn4);
 
var webView = Ti.UI.createWebView({
url: 'https://appcelerator.com/',
top: 150,
});
 
win.add(webView);
win.open();

I see this error when clicking on 'Create PDF of webpage':

[ERROR] �� �Script Error {

[ERROR] �� � column = 20;

[ERROR] �� � line = 52;

[ERROR] �� � message = "webView.createPdf is not a function. (In 'webView.createPdf(function (e) {\n nextWebView.data = e.data;\n nextWin.open();\n })', 'webView.createPdf' is undefined)";

[ERROR] �� � sourceURL = "file:///Users/samir/Library/Developer/CoreSimulator/Devices/448727D1-8F0B-42DE-85D5-01C0CC011310/data/Containers/Bundle/Application/3642309B-ED82-4E33-AEFC-DCC01D9F0595/anewappp.app/app.js";

[ERROR] �� � stack = "file:///Users/samir/Library/Developer/CoreSimulator/Devices/448727D1-8F0B-42DE-85D5-01C0CC011310/data/Containers/Bundle/Application/3642309B-ED82-4E33-AEFC-DCC01D9F0595/anewappp.app/app.js:52:20";

[ERROR] �� � type = TypeError;

[ERROR] �� �}

Test Environment

MacOS Big Sur: 11.0 Beta 5
Xcode: 12.0 Beta 5
Java Version: 1.8.0_242
Android NDK: 21.3.6528147
Node.js: 12.18.1
""NPM":"5.0.0","CLI":"8.1.0-master.11""
iphone 8 Sim (14.0 Beta)
Command line tools 12.0

vijaysingh-axway · 2020-08-31T01:51:52Z

@vijaysingh-axway When testing the following test case:

var win = Ti.UI.createWindow({

backgroundColor: '#fff'
});
 
var nextWin = Ti.UI.createWindow({
backgroundColor: '#fff'
});
 
var closeButton = Ti.UI.createButton({
top: 50,
title: 'Close'
});
 
closeButton.addEventListener('click', function() {
nextWin.close();
});
 
nextWin.add(closeButton);
 
var nextWebView = Ti.UI.createWebView({
top: 100,
});
 
nextWin.add(nextWebView);
 
 
var btn1 = Ti.UI.createButton({
top: 50,
left: 20,
title: 'Search String (Measure)'
});
 
btn1.addEventListener('click',  function() {
webView.findString('Measure', function(e){ // {'caseSensitive': true, 'backward': false, 'wraps': true},
if (e.success) {
alert('Searched string found!');
} else {
alert('Searched string not found!');
}
});
});
 
win.add(btn1);
 
var btn2 = Ti.UI.createButton({
top: 50,
right: 20,
title: 'Create PDF of webpage'
});
 
btn2.addEventListener('click', function() {
webView.createPdf( function(e) {
nextWebView.data = e.data;
nextWin.open();
});
});
 
win.add(btn2);
 
var btn3 = Ti.UI.createButton({
top: 100,
left: 20,
title: 'Create Web Archive of page'
});
 
btn3.addEventListener('click', function() {
webView.createWebArchive(function(e){
nextWebView.data = e.data;
nextWin.open();
});
});
 
win.add(btn3);
 
var btn4 = Ti.UI.createButton({
top: 100,
right: 20,
title: 'Zoom by factor 2'
});
 
btn4.addEventListener('click', function() {
Ti.API.info('zoom level is ', +webView.zoomLevel);
webView.zoomLevel = 2;
Ti.API.info('zoom level is ', +webView.zoomLevel);
});
 
win.add(btn4);
 
var webView = Ti.UI.createWebView({
url: 'https://appcelerator.com/',
top: 150,
});
 
win.add(webView);
win.open();

I see this error when clicking on 'Create PDF of webpage':

[ERROR] �� �Script Error {

[ERROR] �� � column = 20;

[ERROR] �� � line = 52;

[ERROR] �� � message = "webView.createPdf is not a function. (In 'webView.createPdf(function (e) {\n nextWebView.data = e.data;\n nextWin.open();\n })', 'webView.createPdf' is undefined)";

[ERROR] �� � sourceURL = "file:///Users/samir/Library/Developer/CoreSimulator/Devices/448727D1-8F0B-42DE-85D5-01C0CC011310/data/Containers/Bundle/Application/3642309B-ED82-4E33-AEFC-DCC01D9F0595/anewappp.app/app.js";

[ERROR] �� � stack = "file:///Users/samir/Library/Developer/CoreSimulator/Devices/448727D1-8F0B-42DE-85D5-01C0CC011310/data/Containers/Bundle/Application/3642309B-ED82-4E33-AEFC-DCC01D9F0595/anewappp.app/app.js:52:20";

[ERROR] �� � type = TypeError;

[ERROR] �� �}

Test Environment

MacOS Big Sur: 11.0 Beta 5
Xcode: 12.0 Beta 5
Java Version: 1.8.0_242
Android NDK: 21.3.6528147
Node.js: 12.18.1
""NPM":"5.0.0","CLI":"8.1.0-master.11""
iphone 8 Sim (14.0 Beta)
Command line tools 12.0

@ssjsamir My bad. After review comment function createPdf renamed to createPDF but I forgot to update test case. Updated test case. Please verify now. Thanks!

ssjsamir

@vijaysingh-axway LGTM with the updated test case.

build · 2020-09-02T14:48:35Z

The backport to 9_3_X failed:

The process 'git' failed with exit code 128

Check the run for full details
To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Check out the target branch
git checkout 9_3_X
# Make sure it's up to date
git pull
# Check out your branch
git checkout -b backport-11834-to-9_3_X
# Apply the commits from the PR
curl -s https://github.com/appcelerator/titanium_mobile/commit/4016622155bbd3c19cc50978ce3eb29a1e92cb22.patch | git am -3 --ignore-whitespace
curl -s https://github.com/appcelerator/titanium_mobile/commit/ee68717c7056acebb00bc96a3be108c2ba718841.patch | git am -3 --ignore-whitespace
curl -s https://github.com/appcelerator/titanium_mobile/commit/19656c08e8fa8bd72f3e0383b5a0b145adce1d43.patch | git am -3 --ignore-whitespace
curl -s https://github.com/appcelerator/titanium_mobile/commit/a277c5e10f9087feaa68593ab37cb9eba220aed5.patch | git am -3 --ignore-whitespace
curl -s https://github.com/appcelerator/titanium_mobile/commit/6fb29d34a1f9d313159f2661a71d4d3343bacffa.patch | git am -3 --ignore-whitespace
curl -s https://github.com/appcelerator/titanium_mobile/commit/19f236d644bf0856d6ba686e3a7f9f8ffd77ae2b.patch | git am -3 --ignore-whitespace
curl -s https://github.com/appcelerator/titanium_mobile/commit/be5a2ab0002353c010580867d2a6392625a24347.patch | git am -3 --ignore-whitespace
curl -s https://github.com/appcelerator/titanium_mobile/commit/6a0896be4bbae304dae0fb29f10e55f9b0ad3ea5.patch | git am -3 --ignore-whitespace
curl -s https://github.com/appcelerator/titanium_mobile/commit/f803de3c5dd6e9dd4689a87a7181f1949618a732.patch | git am -3 --ignore-whitespace
curl -s https://github.com/appcelerator/titanium_mobile/commit/f0d300074c18483a1af7f86a39a8dc1b2f3bdef6.patch | git am -3 --ignore-whitespace
curl -s https://github.com/appcelerator/titanium_mobile/commit/3db436cca9cc66af59a72ce784162a11e6c0ff09.patch | git am -3 --ignore-whitespace
curl -s https://github.com/appcelerator/titanium_mobile/commit/20e177698bceec025bc6e83147821015afd90466.patch | git am -3 --ignore-whitespace
curl -s https://github.com/appcelerator/titanium_mobile/commit/7288e78af370266a944f699b0f46b4cc0db50ada.patch | git am -3 --ignore-whitespace
curl -s https://github.com/appcelerator/titanium_mobile/commit/59347ebea7571a11981c67c1c194564fcac58dec.patch | git am -3 --ignore-whitespace
curl -s https://github.com/appcelerator/titanium_mobile/commit/26467be0df637fa42e60825b5c998a4c79874b6d.patch | git am -3 --ignore-whitespace
# Push it to GitHub
git push --set-upstream origin backport-11834-to-9_3_X

Then, create a pull request where the base branch is 9_3_X and the compare/head branch is backport-11834-to-9_3_X.

Fixes TIMOB-27987

sgtcoolguy · 2020-09-02T14:50:42Z

manually cherry-picked to 9_3_X

feat(ios): expose new iOS 14 APIs in TI.UI.WebView

4016622

vijaysingh-axway added feature iOS 14 work in progress 🚧 labels Jul 22, 2020

build added this to the 9.2.0 milestone Jul 22, 2020

build requested a review from a team July 22, 2020 01:39

build added ios needs tests 🚨 labels Jul 22, 2020

vijaysingh-axway added 5 commits July 21, 2020 18:53

style: fixed indentation issue

ee68717

Merge branch 'master' into TIMOB-27987_1

24c6be8

feat(ios): expose new iOS 14 APIs in TI.UI.WebView

19656c0

feat(ios): add optional parameters in string search

a277c5e

docs(ios): added docs

6fb29d3

build requested a review from a team July 23, 2020 00:45

build added the docs label Jul 23, 2020

vijaysingh-axway added 2 commits July 22, 2020 18:55

style: fixed linting issue

19f236d

test(ios): added unit test

be5a2ab

build removed the needs tests 🚨 label Jul 23, 2020

vijaysingh-axway added 3 commits July 23, 2020 17:55

style: fixed linting issue

6a0896b

Merge branch 'master' into TIMOB-27987_1

406da87

test(ios): added unit test

f803de3

vijaysingh-axway removed the work in progress 🚧 label Jul 27, 2020

vijaysingh-axway added 6 commits July 29, 2020 11:02

style: fixed linting issue

f0d3000

test(ios): fixed unit tests

3db436c

ci(jenkins): use node with xcode 12

20e1776

Merge branch 'master' into TIMOB-27987_1

09f2935

test(ios): use new constant to check major version

7288e78

Merge branch 'master' into TIMOB-27987_1

be216bf

sgtcoolguy suggested changes Aug 17, 2020

View reviewed changes

test(ios): updated unit tests

59347eb

tidev deleted a comment from sgtcoolguy Aug 19, 2020

vijaysingh-axway added 3 commits August 19, 2020 16:24

test(ios): updated unit tests

26467be

Merge branch 'master' into TIMOB-27987_1

58e1fb6

Merge branch 'master' into TIMOB-27987_1

e041b6a

sgtcoolguy self-requested a review August 27, 2020 13:05

sgtcoolguy approved these changes Aug 27, 2020

View reviewed changes

sgtcoolguy added backport 9_3_X in-qe-testing 🕵 labels Aug 27, 2020

Merge branch 'master' into TIMOB-27987_1

a80e6e9

ssjsamir self-requested a review August 27, 2020 14:13

ssjsamir reviewed Aug 27, 2020

View reviewed changes

ssjsamir self-requested a review September 1, 2020 15:38

ssjsamir approved these changes Sep 1, 2020

View reviewed changes

sgtcoolguy merged commit 840b0d2 into tidev:master Sep 2, 2020

build added the 9_3_X backport failed label Sep 2, 2020

sgtcoolguy pushed a commit that referenced this pull request Sep 2, 2020

feat(ios): expose new iOS 14 APIs in Ti.UI.WebView (#11834)

cd83d3f

Fixes TIMOB-27987

ewanharris removed 9_3_X backport failed labels Sep 2, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(ios): expose new iOS 14 APIs in Ti.UI.WebView #11834

feat(ios): expose new iOS 14 APIs in Ti.UI.WebView #11834

vijaysingh-axway commented Jul 22, 2020

build commented Jul 22, 2020 •

edited

sgtcoolguy commented Jul 28, 2020

sgtcoolguy Aug 17, 2020

vijaysingh-axway Aug 19, 2020

sgtcoolguy left a comment

sgtcoolguy Aug 27, 2020

sgtcoolguy Aug 27, 2020

sgtcoolguy Aug 27, 2020

sgtcoolguy Aug 27, 2020

sgtcoolguy Aug 27, 2020

sgtcoolguy Aug 27, 2020

ssjsamir left a comment

vijaysingh-axway commented Aug 31, 2020

ssjsamir left a comment

build commented Sep 2, 2020

sgtcoolguy commented Sep 2, 2020

	summary: The parameter passed to the <Titanium.UI.WebView.createPDF> or <Titanium.UI.WebView.createWebArchive>callback.
	summary: The parameter passed to the <Titanium.UI.WebView.createPDF> or <Titanium.UI.WebView.createWebArchive> callback.

	@"minimumFontSize" : NUMFLOAT([[[[self wkWebView] configuration] preferences] minimumFontSize]),
	@"minimumFontSize" : NUMFLOAT(self.wkWebView.configuration.preferences.minimumFontSize),

feat(ios): expose new iOS 14 APIs in Ti.UI.WebView #11834

feat(ios): expose new iOS 14 APIs in Ti.UI.WebView #11834

Conversation

vijaysingh-axway commented Jul 22, 2020

build commented Jul 22, 2020 • edited

sgtcoolguy commented Jul 28, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sgtcoolguy left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ssjsamir left a comment

Choose a reason for hiding this comment

vijaysingh-axway commented Aug 31, 2020

ssjsamir left a comment

Choose a reason for hiding this comment

build commented Sep 2, 2020

sgtcoolguy commented Sep 2, 2020

build commented Jul 22, 2020 •

edited