fix(ios): swipe down gallery photo picker does not fire cancel callback #11868
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ssjsamir
approved these changes
Aug 20, 2020
There was a problem hiding this comment.
FR Passed: Tested using the test case from https://jira.appcelerator.org/browse/TIMOB-28067?focusedCommentId=456348&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-456348.
Test Environment
MacOS Big Sur: 11.0 Beta 4
Xcode: 12.0 Beta 5
Java Version: 1.8.0_242
Android NDK: 21.3.6528147
Node.js: 12.18.1
""NPM":"5.0.0","CLI":"8.1.0-master.11""
iphone 8 Sim (14.0 Beta)
ipad pro (14.0)
sgtcoolguy
pushed a commit
that referenced
this pull request
Aug 28, 2020
…ck (#11868) Fixes TIMOB-28067
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.appcelerator.org/browse/TIMOB-28067
In iOS 13+ default model presentation style for photo gallery is 'page sheet'.
To handle swipe down, delegate method implemented.