Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ios): enable swift development in Titanium #11873

Merged
merged 10 commits into from Aug 17, 2020

Conversation

vijaysingh-axway
Copy link
Contributor

@vijaysingh-axway
Copy link
Contributor Author

_build.js changes are from here with minor change.

@build build added this to the 9.2.0 milestone Aug 7, 2020
@build build requested a review from a team August 7, 2020 02:58
@build build added the ios label Aug 7, 2020
@build
Copy link
Contributor

build commented Aug 7, 2020

Fails
🚫 Tests have failed, see below for more information.
Messages
📖

💾 Here's the generated SDK zipfile.

📖 ✊ The commits in this PR match our conventions! Feel free to Rebase and Merge this PR when ready.
📖 ❌ 5 tests have failed There are 5 tests failing and 711 skipped out of 8086 total tests.

Tests:

ClassnameNameTimeError
ios.ipad.Titanium.UI.ImageViewimage error event (14.0)5.001
Error: timeout of 5000ms exceeded
file:///Users/build/Library/Developer/CoreSimulator/Devices/5B6B25D0-3445-48E0-97D6-199BBA69C78B/data/Containers/Bundle/Application/FEB49E63-56BA-46FD-A913-FEEC282BF822/mocha.app/ti-mocha.js:4326:27
ios.iphone.Titanium.Media.AudioPlayer#start, #stop (14.0)25.035
Error: timeout of 5000ms exceeded
file:///Users/build/Library/Developer/CoreSimulator/Devices/B15C936C-AE26-45D6-BA6B-EC640E4DAA5A/data/Containers/Bundle/Application/04DE6308-B9D6-425D-89D8-594FE1B03092/mocha.app/ti-mocha.js:4326:27
ios.iphone.Titanium.UI.WebViewprogress event (14.0)10.002
Error: timeout of 10000ms exceeded
file:///Users/build/Library/Developer/CoreSimulator/Devices/B15C936C-AE26-45D6-BA6B-EC640E4DAA5A/data/Containers/Bundle/Application/04DE6308-B9D6-425D-89D8-594FE1B03092/mocha.app/ti-mocha.js:4290:32
ios.iphone.Titanium.UI.WebViewhtml-script-tag (14.0)10
Error: timeout of 10000ms exceeded
file:///Users/build/Library/Developer/CoreSimulator/Devices/B15C936C-AE26-45D6-BA6B-EC640E4DAA5A/data/Containers/Bundle/Application/04DE6308-B9D6-425D-89D8-594FE1B03092/mocha.app/ti-mocha.js:4290:32
ios.iphone.Titanium.UI.WebView.zoomLevel (14.0)10
Error: timeout of 10000ms exceeded
file:///Users/build/Library/Developer/CoreSimulator/Devices/B15C936C-AE26-45D6-BA6B-EC640E4DAA5A/data/Containers/Bundle/Application/04DE6308-B9D6-425D-89D8-594FE1B03092/mocha.app/ti-mocha.js:4290:32

Generated by 🚫 dangerJS against e339fae

@sgtcoolguy
Copy link
Contributor

@vijaysingh-axway How do we verify this change?

@vijaysingh-axway
Copy link
Contributor Author

@sgtcoolguy I updated 2 unit tests Ti.Platform.id and Ti.Platform.macaddress, which is dependent on a function func appIdentifier() -> String? (extension of TiUtils) which is defined in TiUtils+Addons.swift. If this unit test is successful, which means the swift development is enabled in titanium.

iphone/cli/commands/_build.js Outdated Show resolved Hide resolved
iphone/cli/commands/_build.js Outdated Show resolved Hide resolved
tests/Resources/ti.platform.test.js Outdated Show resolved Hide resolved
tests/Resources/ti.platform.test.js Outdated Show resolved Hide resolved
@sgtcoolguy sgtcoolguy self-requested a review August 17, 2020 18:42
@sgtcoolguy sgtcoolguy merged commit 2b4aa7b into tidev:master Aug 17, 2020
sgtcoolguy pushed a commit that referenced this pull request Aug 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants