Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(android): DateTimeFormat mishandles some combinations of settings on Android 8 #11874

Merged
merged 4 commits into from Aug 7, 2020

Conversation

jquick-axway
Copy link
Contributor

JIRA:
https://jira.appcelerator.org/browse/TIMOB-28073

Note:
We already have a unit test for this issue. That's how we discovered it.

Test:

  1. Build and run the below on Android 8.
  2. Verify the following error does NOT get logged on app startup.
    Failed to generate 'best' date pattern.
  3. Verify displayed date is: 03/31/2020, 8:15:30.123 PM
var date = new Date(Date.UTC(2020, 2, 31, 20, 15, 30, 123));
var formatter = new Intl.DateTimeFormat('en-US', {
	year: 'numeric',
	month: '2-digit',
	day: '2-digit',
	hour: 'numeric',
	minute: '2-digit',
	second: '2-digit',
	fractionalSecondDigits: 3,
	hour12: true,
	timeZone: 'UTC'
});
var window = Ti.UI.createWindow();
window.add(Ti.UI.createLabel({ text: formatter.format(date) }));
window.open();

@build build requested a review from a team August 7, 2020 03:44
@build
Copy link
Contributor

build commented Aug 7, 2020

Messages
📖

💾 Here's the generated SDK zipfile.

📖 ✊ The commits in this PR match our conventions! Feel free to Rebase and Merge this PR when ready.
📖

✅ All tests are passing
Nice one! All 7278 tests are passing.
(There are 708 skipped tests not included in that total)

Generated by 🚫 dangerJS against 8a26dc1

Copy link
Contributor

@garymathews garymathews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: PASS

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants