Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build(iOS): fix to add resources and sources file in widget extension #11920

Merged
merged 6 commits into from Sep 10, 2020
Merged

build(iOS): fix to add resources and sources file in widget extension #11920

merged 6 commits into from Sep 10, 2020

Conversation

vijaysingh-axway
Copy link
Contributor

https://jira.appcelerator.org/browse/TIMOB-27985

When creating widget extension natively, in target name 'Extension' is appended.
e.g. If you add Widget extension and name it 'WidgetExtTest', target name will be 'WidgetExtTestExtension'.

@vijaysingh-axway vijaysingh-axway changed the title fix(iOS): fix to add resources and sources file in widget extension build(iOS): fix to add resources and sources file in widget extension Aug 17, 2020
@build build added this to the 9.2.0 milestone Aug 18, 2020
@build
Copy link
Contributor

build commented Aug 18, 2020 •
edited

Warnings
⚠️

Commit 32e97a45dac54bee2c3737c5f740bdafc95fc87c has a message "fix(iOS): fix to add resources and sources file in widget extension" giving 1 errors:

  • scope must be lower-case
Messages
📖

🚨 This PR has one or more commits with warnings/errors for commit messages not matching our configuration. You may want to squash merge this PR and edit the message to match our conventions, or ask the original developer to modify their history.
📖

✅ All tests are passing
Nice one! All 4905 tests are passing.
(There are 475 skipped tests not included in that total)

Generated by 🚫 dangerJS against 77b1e98

sgtcoolguy
sgtcoolguy approved these changes Aug 18, 2020
View reviewed changes
Copy link
Contributor

@sgtcoolguy sgtcoolguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code change seems simple enough - no idea how to test

@ssekhri
Copy link

ssekhri commented Sep 9, 2020 •
edited

FR Passed
App widgets can be added successfully.
Note: the target for widget extensions needs to be added as <target name="testappExtension"> for a target named testapp.

Verified on:
Mac OS: 10.15.4
SDK: 9.2.0.v20200831133920
Appc CLI: 8.1.0
JDK: 11.0.4
Node: 10.17.0
Studio: 6.0.0.202005141803
Xcode: 12.0 Beta6
iPhone 14.0 simulator, iPad 14.0 simulator

@sgtcoolguy sgtcoolguy merged commit 4b97cec into tidev:master Sep 10, 2020
@build build mentioned this pull request Sep 10, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgtcoolguy sgtcoolguy sgtcoolguy approved these changes

Assignees
No one assigned
Labels
bug in-qe-testing 🕵 ios no tests
Projects
None yet
Milestone
9.2.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@vijaysingh-axway @build @ssekhri @sgtcoolguy