Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ios): restored borderRadius setter #11951

Merged
merged 3 commits into from Aug 25, 2020
Merged

fix(ios): restored borderRadius setter #11951

merged 3 commits into from Aug 25, 2020

Conversation

vijaysingh-axway
Copy link
Contributor

@vijaysingh-axway vijaysingh-axway changed the title fix(ios): restored setter fix(ios): restored borderRadius setter Aug 24, 2020
@build build added this to the 9.2.0 milestone Aug 25, 2020
@build build requested a review from a team August 25, 2020 00:11
@build build added the ios label Aug 25, 2020
@build
Copy link
Contributor

build commented Aug 25, 2020 •
edited

Messages
📖

💾 Here's the generated SDK zipfile.
📖 ✊ The commits in this PR match our conventions! Feel free to Rebase and Merge this PR when ready.
📖

✅ All tests are passing
Nice one! All 7388 tests are passing.
(There are 711 skipped tests not included in that total)

Generated by 🚫 dangerJS against 89e9dab

garymathews
garymathews approved these changes Aug 25, 2020
View reviewed changes
Copy link
Contributor

@garymathews garymathews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: PASS

@vijaysingh-axway vijaysingh-axway modified the milestones: 9.2.0, 9.1.0 Aug 25, 2020
@ssekhri
Copy link

ssekhri commented Aug 25, 2020

FR Passed.
Verified on:
Mac OS: 10.15.4
SDK: 9.2.0.v20200824171738
Appc CLI: 8.1.0-master.12
JDK: 11.0.4
Node: 10.17.0
Studio: 6.0.0.202005141803
Xcode: 12.0 beta
iPhone X(v13.4)

@ssekhri ssekhri merged commit 0bc833d into tidev:master Aug 25, 2020
@build build mentioned this pull request Aug 25, 2020
Merged
sgtcoolguy pushed a commit that referenced this pull request Sep 9, 2020
@vijaysingh-axway @sgtcoolguy
fix(ios): restored borderRadius setter (#11951)
7976f16 
* fix(ios): restored setter

* test: added unit test

* test(ios): make it ios specific
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@garymathews garymathews garymathews approved these changes

@sgtcoolguy sgtcoolguy Awaiting requested review from sgtcoolguy

Assignees
No one assigned
Labels
ios
Projects
None yet
Milestone
9.1.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@vijaysingh-axway @build @ssekhri @garymathews