New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(android)(9_3_X): add "tapjacking" prevention features #11962
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added boolean property "filterTouchesWhenObscured" to all Ti.UI.View dervied types. - Added event "touchfiltered" event to Ti.UI.Button. - Added boolean property "obscured" to all touch related events. * Will only be true if "filterTouchesWhenObscured" is false. Fixes TIMOB-28080
Tests:
|
garymathews
reviewed
Aug 26, 2020
garymathews
approved these changes
Aug 26, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CR: PASS
Minor comment about test case.
jquick-axway
added
the
backport master
when applied, PRs with this label will get an auto-generated backport to master branch on merge
label
Sep 21, 2020
ssjsamir
approved these changes
Sep 28, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FR Passed, tested using the example in the description.
Test Environment
MacOS Big Sur: 11.0 Beta 7
Xcode: 12.0
Java Version: 1.8.0_242
Android NDK: 21.3.6528147
Node.js: 12.18.1
""NPM":"5.0.0","CLI":"8.1.1""
Pixel XL (10.0)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
android
backport master
when applied, PRs with this label will get an auto-generated backport to master branch on merge
docs
feature
in-qe-testing 🕵
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA:
https://jira.appcelerator.org/browse/TIMOB-28080
Note:
Tapjacking is an Android exploit where a malicious app can display a translucent system overlay on top of other apps used to intercept touches or to trick the end-user to tapping on the overlay.
Summary:
Ti.UI.View
derived types.Ti.UI.Button
.true
and touch was obscured by overlay.false
.Test:
adb install -r <PathToApk>
app.js