Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add Ti.Platform.versionPatch and global.OS_VERSION_PATCH #11967

Merged
merged 6 commits into from Aug 31, 2020
Merged

feat: add Ti.Platform.versionPatch and global.OS_VERSION_PATCH #11967

merged 6 commits into from Aug 31, 2020

Conversation

sgtcoolguy
Copy link
Contributor

JIRA: https://jira.appcelerator.org/browse/TIMOB-28098

Description:
Follow-on to #11859

This may not be quite as useful generally as major/minor - but in working on the macOS support, the third version segment can be fairly useful to know.

@build build added this to the 9.2.0 milestone Aug 26, 2020
@build build requested review from a team August 26, 2020 15:07
@build
Copy link
Contributor

build commented Aug 26, 2020

Fails
🚫 Tests have failed, see below for more information.
Messages
📖

💾 Here's the generated SDK zipfile.
📖 ✊ The commits in this PR match our conventions! Feel free to Rebase and Merge this PR when ready.
📖 ❌ 1 tests have failed There are 1 tests failing and 711 skipped out of 8102 total tests.

Tests:

ClassnameNameTimeError
ios.ipad.Titanium.UI.iOS.CollisionBehavior.exampleworks (14.0)10.002
Error: timeout of 10000ms exceeded
file:///Users/build/Library/Developer/CoreSimulator/Devices/AEB0AAF4-FED7-4BF5-8DDC-233DE4C6A1FF/data/Containers/Bundle/Application/323BB384-3B17-42C8-B0FF-EF115CADB4C2/mocha.app/ti-mocha.js:4326:27

Generated by 🚫 dangerJS against 6679ae0

jquick-axway
jquick-axway approved these changes Aug 26, 2020
View reviewed changes
Copy link
Contributor

@jquick-axway jquick-axway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: Pass

@sgtcoolguy sgtcoolguy merged commit 2c4ec72 into tidev:master Aug 31, 2020
@sgtcoolguy sgtcoolguy deleted the versionpatch branch August 31, 2020 13:02
@build build mentioned this pull request Aug 31, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jquick-axway jquick-axway jquick-axway approved these changes

Assignees
No one assigned
Labels
android docs improvement in-qe-testing 🕵 ios parity 👯‍♀️
Projects
None yet
Milestone
9.2.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sgtcoolguy @build @jquick-axway