fix(ios): use arc to create corner radius instead of qudratic curve #11969
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tests:
|
sgtcoolguy
reviewed
Aug 27, 2020
sgtcoolguy
reviewed
Aug 27, 2020
sgtcoolguy
suggested changes
Aug 27, 2020
sgtcoolguy
reviewed
Aug 31, 2020
|
@vijaysingh-axway could we add a test with |
viewShadow issue is not fixed this PR. I am working on this as part of https://jira.appcelerator.org/browse/TIMOB-28103 |
sgtcoolguy
approved these changes
Sep 2, 2020
ssjsamir
approved these changes
Sep 3, 2020
There was a problem hiding this comment.
FR Passed, able to use arc to create corner radius instead of quadratic curve. Tested using the following test cases:
const window = Ti.UI.createWindow({ backgroundColor: 'white' });
const view = Ti.UI.createView({
backgroundColor: 'red',
width: 100,
height: 100,
borderRadius: '50 50 50 50'
});
window.add(view);
window.open();
var _window = Ti.UI.createWindow({
backgroundColor : 'blue'
});
var view = Ti.UI.createView({
left : 10,
height : 100,
width : 100,
top : 10,
backgroundColor : 'white',
borderWidth : 20,
borderColor : 'red',
borderRadius : 10
});
var b3 = Ti.UI.createButton({
top : 250,
title : "borderRadius=30/20"
});
b3.addEventListener("click", function() {
view.borderRadius = ['30', '20', '30', '20'];
});
var b4 = Ti.UI.createButton({
top : 300,
title : "borderRadius=30 All"
});
b4.addEventListener("click", function() {
view.borderRadius = 30;
});
var b5 = Ti.UI.createButton({
top : 350,
title : "borderRadius=0"
});
b5.addEventListener("click", function() {
view.borderRadius = 0;
});
_window.add(view);
_window.add(b3);
_window.add(b4);
_window.add(b5);
_window.open();
var win = Ti.UI.createWindow({
backgroundColor: '#333'
});
var view = Ti.UI.createView({
backgroundColor: '#fff',
height: 350,
bottom: 0,
borderRadius: '20 20dp 20px 12px',
});
win.add(view);
win.open();
Test Environment
MacOS Big Sur: 11.0 Beta 5
Xcode: 12.0 Beta 5
Java Version: 1.8.0_242
Android NDK: 21.3.6528147
Node.js: 12.18.1
""NPM":"5.0.0","CLI":"8.1.0-master.11""
iphone 8 Sim (14.0 Beta)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.appcelerator.org/browse/TIMOB-28101