Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ios): update liveview for ios 14 compatibility #11976

Merged
merged 2 commits into from Aug 31, 2020

Conversation

ewanharris
Copy link
Collaborator

Fixes TIMOB-28091

JIRA: https://jira.appcelerator.org/browse/TIMOB-28091

Requires #11897 to have been merged first

Putting straight into QE test

@hansemannn
Copy link
Collaborator

hansemannn commented Aug 28, 2020

@ewanharris Is there a plan to open source LiveView at some point? Since it can be publicly downloaded already, but having the ability to see proper tags and changelogs in the repo + the obvious chance to contribute would be great!

@build build added this to the 9.2.0 milestone Aug 28, 2020
@build
Copy link
Contributor

build commented Aug 28, 2020

Fails
🚫 Tests have failed, see below for more information.
Messages
📖 👍 Hey!, You deleted more code than you added. That's awesome!
📖

💾 Here's the generated SDK zipfile.

📖 ✊ The commits in this PR match our conventions! Feel free to Rebase and Merge this PR when ready.
📖 ❌ 1 tests have failed There are 1 tests failing and 711 skipped out of 8040 total tests.

Tests:

ClassnameNameTimeError
android.emulator.Titanium.Network.HTTPClientsend on response (9)0.997
Error: done() invoked with non-Error: [object Object]
at /ti-mocha.js:6535:53959
      at HTTPClient.xhr.onerror (/ti.network.httpclient.test.js:641:16)

Dependencies with modified semantic versioning:

Generated by 🚫 dangerJS against 3fe47b4

@ewanharris
Copy link
Collaborator Author

@hansemannn, we discussed it a few months back now and I believe we landed on the decision to do that.
However it hasn't been a high priority and does require some work to clean up the repo to get it to a place where people could actually contribute to it.

@ssekhri
Copy link

ssekhri commented Aug 31, 2020

FR Passed.
Verified on:
Mac OS: 10.15.4
SDK: 9.2.0.v20200831085101
Appc CLI: 8.1.0
JDK: 11.0.4
Node: 10.17.0
Studio: 6.0.0.202005141803
Xcode: 12.0 Beta 6
Device: iPhone 7 Plus(v14.0 Beta6)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants