Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TIMOB-28108] Allow tintColor to accept a semantic color #12002

Merged
merged 2 commits into from Sep 3, 2020

Conversation

Topener
Copy link
Sponsor Contributor

@Topener Topener commented Sep 2, 2020

JIRA: https://jira.appcelerator.org/browse/TIMOB-28108

Used solution implemented in other parts of the SDK

@jquick-axway jquick-axway added this to the 9.2.0 milestone Sep 2, 2020
@build build requested a review from a team September 2, 2020 16:56
@build
Copy link
Contributor

build commented Sep 2, 2020

Fails
🚫 Tests have failed, see below for more information.
Warnings
⚠️

Commit b2d70b9c7878ec98c5d7bd24d236e8975a815bf0 has a message "Allow tintColor to accept a semantic color" giving 2 errors:

  • subject may not be empty
  • type may not be empty
Messages
📖 👍 Hey!, You deleted more code than you added. That's awesome!
📖

💾 Here's the generated SDK zipfile.

📖

🚨 This PR has one or more commits with warnings/errors for commit messages not matching our configuration. You may want to squash merge this PR and edit the message to match our conventions, or ask the original developer to modify their history.

📖 ❌ 2 tests have failed There are 2 tests failing and 711 skipped out of 8140 total tests.

Tests:

ClassnameNameTimeError
android.emulator.Titanium.Network.HTTPClientTIMOB-23127 (9)60.06
Error: timeout of 60000ms exceeded
at Titanium.<anonymous> (/ti-mocha.js:6535:53723)
ios.ipad.Titanium.Network.Socket.TCP#connect() and #write() async (14.0)7.923
Error: done() invoked with non-Error: [object Object]
file:///Users/build/Library/Developer/CoreSimulator/Devices/0035AEF4-D58B-4282-9C16-4D3301CDDBFC/data/Containers/Bundle/Application/00E1BB1C-C8A7-46C2-8812-A8BBA5CCCADA/mocha.app/ti-mocha.js:4361:52
error@file:///Users/build/Library/Developer/CoreSimulator/Devices/0035AEF4-D58B-4282-9C16-4D3301CDDBFC/data/Containers/Bundle/Application/00E1BB1C-C8A7-46C2-8812-A8BBA5CCCADA/mocha.app/ti.network.socket.tcp.test.js:133:15

Generated by 🚫 dangerJS against 47b50ce

Copy link
Contributor

@vijaysingh-axway vijaysingh-axway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ssekhri
Copy link

ssekhri commented Sep 2, 2020

FR Passed
Verified on:
Mac OS: 10.15.4
SDK: 9.2.0.v20200902093855
Appc CLI: 8.1.0
JDK: 11.0.4
Node: 10.17.0
Studio: 6.0.0.202005141803
Xcode: 12.0 Beta6
iPhone 7Plus(v14.0 Beta6), iPhone X (13.6.1)

@build
Copy link
Contributor

build commented Sep 3, 2020

The backport to 9_1_X failed:

The process 'git' failed with exit code 128

Check the run for full details
To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Check out the target branch
git checkout 9_1_X
# Make sure it's up to date
git pull
# Check out your branch
git checkout -b backport-12002-to-9_1_X
# Apply the commits from the PR
curl -s https://github.com/appcelerator/titanium_mobile/commit/b2d70b9c7878ec98c5d7bd24d236e8975a815bf0.patch | git am -3 --ignore-whitespace
# Push it to GitHub
git push --set-upstream origin backport-12002-to-9_1_X

Then, create a pull request where the base branch is 9_1_X and the compare/head branch is backport-12002-to-9_1_X.

sgtcoolguy pushed a commit that referenced this pull request Sep 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants