Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ios): use TITANIUM_SDK variable to point at xcframework path in xcode project #12090

Merged
merged 2 commits into from Sep 17, 2020

Conversation

sgtcoolguy
Copy link
Contributor

@sgtcoolguy sgtcoolguy commented Sep 16, 2020

JIRA: https://jira.appcelerator.org/browse/TIMOB-28143

Description:
This was informally discussed on Teams, so there is no JIRA ticket yet. If you create a module with a 9.2.x SDK, the module template baked in the path of that SDK's version of the TitaniumKit.xcframework. This change makes the file path reference use the $(TITANIUM_SDK) variable in the path so that when users/developers update the ios/titanium.xcconfig file to target a specific SDK version, that will get reflected into the xcframework reference.

I did this manually in the apple sign in module when I added xcframework/Mac support: tidev/titanium-apple-sign-in@0103242#diff-ab2479047e1642c6a102069cd6069bb2R24

@build
Copy link
Contributor

build commented Sep 16, 2020

Fails
🚫 Tests have failed, see below for more information.
Warnings
⚠️ This PR has milestone set to 9.2.0, but the version defined in package.json is 9.3.0 Please either: - Update the milestone on the PR - Update the version in package.json - Hold the PR to be merged later after a release and version bump on this branch
Messages
📖

💾 Here's the generated SDK zipfile.

📖 ✊ The commits in this PR match our conventions! Feel free to Rebase and Merge this PR when ready.
📖 ❌ 3 tests have failed There are 3 tests failing and 980 skipped out of 10931 total tests.

Tests:

ClassnameNameTimeError
android.emulator.Titanium.Filesystem.File#rename() renames file within same directory (11)0.002
Error: expected false to be true
at Assertion.fail (/node_modules/should/cjs/should.js:275:13)
      at Assertion.value (/node_modules/should/cjs/should.js:356:9)
      at Context.<anonymous> (/ti.filesystem.file.test.js:637:42)
      at Test.Runnable.run (/ti-mocha.js:6535:54163)
      at Runner.runTest (/ti-mocha.js:6535:58604)
      at /ti-mocha.js:6535:59445
      at next (/ti-mocha.js:6535:58013)
      at /ti-mocha.js:6535:57975
      at next (/ti-mocha.js:6535:57665)
      at /ti-mocha.js:6535:57759
ios.ipad.Titanium.UI.iOS.CollisionBehavior.exampleworks (14.0)15.002
Error: timeout of 15000ms exceeded
file:///Users/build/Library/Developer/CoreSimulator/Devices/6C7D2BAE-178F-423C-B035-5B9A681D728F/data/Containers/Bundle/Application/B5008C31-2C84-4649-A0ED-27B4D45A28A5/mocha.app/ti-mocha.js:4326:27
ios.macos.Titanium.UI.View.borderRadius corners1 value with shadow effect (10.15.5)0.068
Error: expected 'Ti.UI.View' view to match snapshot image: snapshots/borderRadiusWithShadow30px.png
fail@file:///Users/build/jenkins/workspace/ium-sdk_titanium_mobile_PR-12090/tmp/mocha/build/iphone/build/Products/Debug-maccatalyst/mocha.app/Contents/Resources/node_modules/should/cjs/should.js:275:23
value@file:///Users/build/jenkins/workspace/ium-sdk_titanium_mobile_PR-12090/tmp/mocha/build/iphone/build/Products/Debug-maccatalyst/mocha.app/Contents/Resources/node_modules/should/cjs/should.js:356:23
postlayout@file:///Users/build/jenkins/workspace/ium-sdk_titanium_mobile_PR-12090/tmp/mocha/build/iphone/build/Products/Debug-maccatalyst/mocha.app/Contents/Resources/ti.ui.view.test.js:1232:39

Generated by 🚫 dangerJS against 05cb85a

Copy link
Contributor

@vijaysingh-axway vijaysingh-axway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR passed. In my test it is working fine!

@lokeshchdhry
Copy link
Contributor

FR Passed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants