New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ios): use TITANIUM_SDK variable to point at xcframework path in xcode project #12090
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tests:
|
vijaysingh-axway
approved these changes
Sep 16, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CR passed. In my test it is working fine!
FR Passed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: https://jira.appcelerator.org/browse/TIMOB-28143
Description:
This was informally discussed on Teams, so there is no JIRA ticket yet. If you create a module with a 9.2.x SDK, the module template baked in the path of that SDK's version of the TitaniumKit.xcframework. This change makes the file path reference use the
$(TITANIUM_SDK)
variable in the path so that when users/developers update theios/titanium.xcconfig
file to target a specific SDK version, that will get reflected into the xcframework reference.I did this manually in the apple sign in module when I added xcframework/Mac support: tidev/titanium-apple-sign-in@0103242#diff-ab2479047e1642c6a102069cd6069bb2R24