Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ios): support iOS 14+ App Clips #12107

Merged
merged 3 commits into from Sep 22, 2020
Merged

feat(ios): support iOS 14+ App Clips #12107

merged 3 commits into from Sep 22, 2020

Conversation

hansemannn
Copy link
Collaborator

@hansemannn hansemannn mentioned this pull request Sep 20, 2020
Closed
@build build added this to the 9.3.0 milestone Sep 20, 2020
@build
Copy link
Contributor

build commented Sep 20, 2020 •
edited

Messages
📖

💾 Here's the generated SDK zipfile.
📖 🎉 Another contribution from our awesome community member, hansemannn! Thanks again for helping us make Titanium SDK better. 👍
📖 ✊ The commits in this PR match our conventions! Feel free to Rebase and Merge this PR when ready.
📖

✅ All tests are passing
Nice one! All 9770 tests are passing.
(There are 981 skipped tests not included in that total)

Generated by 🚫 dangerJS against 5deda10

@sgtcoolguy sgtcoolguy requested a review from a team September 21, 2020 14:25
@sgtcoolguy
Copy link
Contributor

LGTM but @vijaysingh-axway and @janvennemann should review/weigh in

@vijaysingh-axway
Copy link
Contributor

In my initial testing I found-

  1. In cli we do not have any command from which developer can launch AppClip in device, to verify the changes in app clip target. But they can run app clip from generated Xcode project. (I think this should be okey. We can create a cli ticket for same which can be done later).

  2. Build failed due to Bundle version mismatch from app clip. For this use same version (available in tiapp.xml ) in created native app clip(go to app clip target->general- > Build) cc QE.

vijaysingh-axway
vijaysingh-axway approved these changes Sep 22, 2020
View reviewed changes
Copy link
Contributor

@vijaysingh-axway vijaysingh-axway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes looks good.
The added comments in PR are basically to ease the testing and may be add in release doc somewhere.

@lokeshchdhry
Copy link
Contributor

FR Passed.

@lokeshchdhry lokeshchdhry merged commit 1f7d44a into tidev:master Sep 22, 2020
@build build mentioned this pull request Sep 23, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vijaysingh-axway vijaysingh-axway vijaysingh-axway approved these changes

Assignees
No one assigned
Labels
cli 📟 community 🔥 improvement in-qe-testing 🕵 ios no tests
Projects
None yet
Milestone
9.3.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@hansemannn @build @sgtcoolguy @vijaysingh-axway @lokeshchdhry