Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(android): update websocket lib for JS debugging #12119

Merged
merged 4 commits into from Oct 7, 2020

Conversation

jquick-axway
Copy link
Contributor

@jquick-axway jquick-axway commented Sep 22, 2020

JIRA:
https://jira.appcelerator.org/browse/TIMOB-28149

Summary:

  • Updated Java-WebSocket library to v1.5.1.
  • Now references library via gradle instead of local JAR.
    • Avoids name collision build failures.

Test:
Verify debugging/breakpoints still work in Appc Studio and VS Code.

- Updated Java-WebSocket library to v1.5.1.
- Now references library via gradle instead of local JAR. (Avoids name collision build failures.)

Fixes TIMOB-28149
@build
Copy link
Contributor

build commented Sep 22, 2020

Messages
📖 👍 Hey!, You deleted more code than you added. That's awesome!
📖

💾 Here's the generated SDK zipfile.

📖 ✊ The commits in this PR match our conventions! Feel free to Rebase and Merge this PR when ready.
📖

✅ All tests are passing
Nice one! All 9968 tests are passing.
(There are 984 skipped tests not included in that total)

Generated by 🚫 dangerJS against 90e248b

@ssaddique
Copy link
Contributor

FR Passed.

Test environment
SDK Ver: this PR
OS Ver: 10.15.6
Appc NPM: 5.0.0
Appc CLI: 8.1.1
Node Ver: 10.17.0
NPM Ver: 6.13.6
Java Ver: 1.8.0_162

@sgtcoolguy sgtcoolguy merged commit 4d1c928 into tidev:master Oct 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants