fix(ios): guard PHPicker usage with openPhotoGallery #12129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes TIMOB-28151
|
hansemannn
reviewed
Sep 24, 2020
| @@ -1784,7 +1784,7 @@ - (void)handleTrimmedVideo:(NSURL *)theURL withDictionary:(NSDictionary *)dictio | |||
| } | |||
| #endif | |||
|
|
|||
| #if IS_SDK_IOS_14 | |||
| #if IS_SDK_IOS_14 && defined(USE_TI_MEDIAOPENPHOTOGALLERY) | |||
There was a problem hiding this comment.
You may also need to check it's delegate methods, but not sure if they're also affected.
There was a problem hiding this comment.
delegate methods appear to already be guarded
sgtcoolguy
approved these changes
Sep 24, 2020
|
To reproduce: var window = Ti.UI.createWindow();
Ti.Media.beep();
window.open();Then you must build for device: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes TIMOB-28151
JIRA: https://jira.appcelerator.org/browse/TIMOB-28151
Guard the usage of PHPicker with
defined(USE_TI_MEDIAOPENPHOTOGALLERY)otherwise 💥