Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ios): disable default animation while setting backgroundImage #12133

Merged
merged 3 commits into from Sep 28, 2020
Merged

fix(ios): disable default animation while setting backgroundImage #12133

merged 3 commits into from Sep 28, 2020

Conversation

vijaysingh-axway
Copy link
Contributor

@build build added this to the 9.3.0 milestone Sep 25, 2020
@build build requested a review from a team September 25, 2020 00:21
@build
Copy link
Contributor

build commented Sep 25, 2020 •
edited

Fails
🚫 Tests have failed, see below for more information.
Messages
📖

💾 Here's the generated SDK zipfile.
📖 ✊ The commits in this PR match our conventions! Feel free to Rebase and Merge this PR when ready.
📖 ❌ 1 tests have failed There are 1 tests failing and 981 skipped out of 10946 total tests.

Tests:

ClassnameNameTimeError
android.emulator.Titanium.UI.Android.ProgressIndicatordialog indeterminant - show in different windows (11)5.18
Error: timeout of 5000ms exceeded
at Titanium.<anonymous> (/ti-mocha.js:6535:53723)

Generated by 🚫 dangerJS against 50aabf4

@lokeshchdhry
Copy link
Contributor

FR Passed.

Updating background works as expected.

Studio Ver: 6.0.0.202005141803
SDK Ver: local build
OS Ver: 10.15.5
Xcode Ver: Xcode 12.0
Appc NPM: 5.0.0
Appc CLI: 8.1.1
Daemon Ver: 3.2.0
Ti CLI Ver: 5.2.5
Alloy Ver: 1.15.2
Node Ver: 12.13.1
NPM Ver: 6.14.7
Java Ver: 11.0.6
IOS Devices: ⇨ iPhone7s 14.0

@sgtcoolguy sgtcoolguy merged commit ecca0d1 into tidev:master Sep 28, 2020
@build build mentioned this pull request Sep 28, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@janvennemann janvennemann janvennemann approved these changes

Assignees
No one assigned
Labels
bug in-qe-testing 🕵 ios no tests
Projects
None yet
Milestone
9.3.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@vijaysingh-axway @build @lokeshchdhry @janvennemann @sgtcoolguy