fix(ios): explicitly return null if source exists and hasn't changed #12135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
copyDirSync expects a return value of null, otherwise it will copy the file over. As certain files require the contents to have been ran through _scrubiOSSourceFile, copying over the un-scrubbed file will cause the code to become invalid and have an impact on other files causing a potential compile time error Fixes TIMOB-28152
sgtcoolguy
approved these changes
Sep 28, 2020
ssjsamir
approved these changes
Sep 29, 2020
There was a problem hiding this comment.
FR Passed: Able to build when SDK compile a rebuild.
Test Steps:
- Install 9.2.0.v20200923092031 and and the SDK from this PR
- Set apps SDK to 9.2.0.v20200923092031
- Run appc run -p ios -T device --build-only
- Set apps SDK to 9.3.0
- Run appc run -p ios -T device --build-only
Test Environment
MacOS Big Sur: 11.0 Beta 7
Xcode: 12.0
Java Version: 1.8.0_242
Android NDK: 21.3.6528147
Node.js: 12.18.1
""NPM":"5.0.0","CLI":"8.1.1""
iphone 11(14.0)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: https://jira.appcelerator.org/browse/TIMOB-28152
copyDirSync expects a return value of null, otherwise it will copy the file over. As certain files
require the contents to have been ran through _scrubiOSSourceFile, copying over the un-scrubbed file
will cause the code to become invalid and have an impact on other files causing a potential compile
time error