Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ios): check for thirdparty framework path #12142

Merged
merged 1 commit into from Oct 1, 2020
Merged

fix(ios): check for thirdparty framework path #12142

merged 1 commit into from Oct 1, 2020

Conversation

vijaysingh-axway
Copy link
Contributor

@build build added this to the 9.3.0 milestone Sep 30, 2020
@build
Copy link
Contributor

build commented Sep 30, 2020 •
edited

Fails
🚫 Tests have failed, see below for more information.
Warnings
⚠️

iphone/cli/commands/_buildModule.js#L142 - iphone/cli/commands/_buildModule.js line 142 – Avoid calling back inside of a promise. (promise/no-callback-in-promise)
⚠️

iphone/cli/commands/_buildModule.js#L142 - iphone/cli/commands/_buildModule.js line 142 – Expected catch() or return (promise/catch-or-return)
Messages
📖

💾 Here's the generated SDK zipfile.
📖 ✊ The commits in this PR match our conventions! Feel free to Rebase and Merge this PR when ready.
📖 ❌ 1 tests have failed There are 1 tests failing and 981 skipped out of 10896 total tests.

Tests:

ClassnameNameTimeError
android.emulator.fs#copyFile() copies file asynchronously to destination (11)0.042
Error: expected false to be true
at Assertion.fail (/node_modules/should/cjs/should.js:275:13)
      at Assertion.value (/node_modules/should/cjs/should.js:356:9)
      at /fs.test.js:204:35
      at Stream.<anonymous> (<embedded>:9815:5)

Generated by 🚫 dangerJS against 3a62d19

sgtcoolguy
sgtcoolguy approved these changes Sep 30, 2020
View reviewed changes
Copy link
Contributor

@sgtcoolguy sgtcoolguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, simple existence guard

@ssekhri
Copy link

ssekhri commented Sep 30, 2020

FR Passed.
Verified on:
Mac OS: 10.15.4
SDK: 9.3.0.v20200929171454
Appc CLI: 8.1.1
JDK: 11.0.4
Node: 10.17.0
Xcode: 12.0

@sgtcoolguy sgtcoolguy merged commit 99c6d69 into tidev:master Oct 1, 2020
@build build mentioned this pull request Oct 1, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgtcoolguy sgtcoolguy sgtcoolguy approved these changes

Assignees
No one assigned
Labels
bug in-qe-testing 🕵 no tests
Projects
None yet
Milestone
9.3.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@vijaysingh-axway @build @ssekhri @sgtcoolguy