refactor(android): media/file APIs to use scoped storage #12143

jquick-axway · 2020-10-01T07:35:15Z

JIRA:

Summary:

TIMOB-28059 Modified Ti.Media.showCamera() and saveToPhotoGallery() to use scoped storage.
- No longer requires external storage permission on Android 10 and higher.
Camera Overlay Changes:
- TIMOB-27481 Fixed bug where navigating back would may wrongly exit out of the app.
- TIMOB-26602 Fixed bug where Ti.Media.takePicture() may use the wrong file extension.
Fixed Ti.Media.VideoPlayer crash which can occur if error callback is invoked during playback.
TIMOB-28183 Added media methods:
- Ti.Media.hasPhotoGalleryPermissions()
- Ti.Media.requestPhotoGalleryPermissions()
TIMOB-27201 Updated Ti.Filesystem.File APIs when wrapping "content://" URL.
- Added: createdAt(), deleteFile(), exists(), extension(), modifiedAt(), read(), readonly, write(), writable
- Missing: createDirectory(), open(), readLine()
Optimized Ti.Filesystem.File object's move() method when performed on same volume.
Updated Ti.Filesystem.File object's rename() to support absolute path in same folder.
Renamed TitaniumBlob.java to TiContentFile.java.
- New name better indicates it supports "content://" URLs.
Removed unused "ti.android.enablecoverage" related code. (Was never supported.)

Camera Photo Test:
(Run this test on Android 11 and Android 4.4.)

Create a Classic Titanium app with the below "tiapp.xml" settings.
Build and run "CameraPhotoExternalTest.js" attached to TIMOB-28059.
Tap on the "Take Picture" button.
On Android 6.0 and higher, verify app requests permission. Agree to it.
Verify a camera window appears.
Tap the Back button to go back to the app. Verify app does not exit.
Tap on the "Take Picture" button.
Take a picture and hit okay in the camera window.
Verify the photo you taken is displayed by the Titanium app.
In the JS code, uncomment line: // saveToPhotoGallery: true
Repeat steps 3-9.
Go to the Photos/Gallery app and verify you can find your photo there.
Build and run "CameraPhotoInternalTest.js" attached to TIMOB-28059.
Repeat steps 3-12.

<ti:app>
	<android>
		<manifest>
			<uses-sdk android:targetSdkVersion="30"/>
			<uses-permission android:name="android.permission.CAMERA"/>
		</manifest>
	</android>
</ti:app>

Camera Video Test:
(Run this test on Android 11 and Android 4.4.)

Create a Classic Titanium app with the below "tiapp.xml" settings.
Build and run "CameraVideoExternalTest.js" attached to TIMOB-28059.
Tap on the "Capture Video" button.
On Android 6.0 and higher, verify app requests permission. Agree to it.
Verify a camera window appears.
Tap the Back button to go back to the app. Verify app does not exit.
Tap on the "Capture Video" button.
Record video and hit okay in the camera window.
Verify the Titanium app displays and plays your video.
In the JS code, uncomment line: // saveToPhotoGallery: true
Repeat steps 3-9.
Go to the Photos/Gallery app and verify you can find your video there.
Build and run "CameraVideoInternalTest.js" attached to TIMOB-28059.
Repeat steps 3-12.

<ti:app>
	<android>
		<manifest>
			<uses-sdk android:targetSdkVersion="30"/>
			<uses-permission android:name="android.permission.CAMERA"/>
			<uses-permission android:name="android.permission.RECORD_AUDIO"/>
		</manifest>
	</android>
</ti:app>

Save Image File to Gallery Test:
(Run this test on Android 11 and Android 4.4.)

Create a Classic Titanium app with the below "tiapp.xml" setting.
Build and run "ImageToGalleryTest.js" attached to TIMOB-28059.
Tap on the "Save Screenshot to Gallery" button.
Verify an alert displays it was successful.
Open the Photos/Gallery app and verify you can find the screenshot there.

<ti:app>
	<android>
		<manifest>
			<uses-sdk android:targetSdkVersion="30"/>
		</manifest>
	</android>
</ti:app>

- TIMOB-27201: Updated Ti.Filesystem.File to support below APIs when wrapping "content://" URL: * createdAt(), deleteFile(), exists(), modifiedAt(), read(), readonly, write(), writable - Updated Ti.Filesystem.File to support below APIs when resource files: * createdAt(). modifiedAt() - Optimized Ti.Filesystem.File move() when performed on the same volume. - TIMOB-28146: Updated Ti.Filesystem.File rename() to support absolute path in same directory and source. Fixes TIMOB-27201, TIMOB-28146

- TIMOB-28059: Modified Ti.Media.showCamera() and saveToPhotoGallery() to use scoped storage. * Removed requirement for WRITE_EXTERNAL_STORAGE and READ_EXTERNAL_STORAGE permissions. - TIMOB-27481: Fixed bug where navigating back from camera overlay may wrongly close the app. - TIMOB-26602: Fixed bug where Ti.Media.takePicture() may use wrong file extension. - Fixed Ti.Media.VideoPlayer crash that can occur if error callback is invoked during playback. Fixes TIMOB-28059, TIMOB-27481, TIMOB-26602

build · 2020-10-01T08:01:32Z

	Warnings
⚠️	Commit f6bb5b1da38151f65a2ffbcbb5a9eb7c5e9e89e2 has a message "refactor(android): content url and resource file handling TIMOB-27201: Updated Ti.Filesystem.File to support below APIs when wrapping "content://" URL: createdAt(), deleteFile(), exists(), modifiedAt(), read(), readonly, write(), writable Updated Ti.Filesystem.File to support below APIs when resource files: createdAt(). modifiedAt() Optimized Ti.Filesystem.File move() when performed on the same volume. TIMOB-28146: Updated Ti.Filesystem.File rename() to support absolute path in same directory and source. Fixes TIMOB-27201, TIMOB-28146" giving 1 errors: body's lines must not be longer than 100 characters
⚠️	Commit 89c5a5f05b009feee546378904fc67fc1ca2ec04 has a message "Merged" giving 2 errors: subject may not be empty type may not be empty
⚠️	build/lib/test/test.js#L455 - build/lib/test/test.js line 455 – 'stripped' is defined but never used. Allowed unused args must match /^_.+/u. (no-unused-vars)
⚠️	build/lib/test/test.js#L795 - build/lib/test/test.js line 795 – Missing JSDoc parameter description for 'testResults'. (valid-jsdoc)

	Messages
📖	💾 Here's the generated SDK zipfile.
📖	🚨 This PR has one or more commits with warnings/errors for commit messages not matching our configuration. You may want to squash merge this PR and edit the message to match our conventions, or ask the original developer to modify their history.
📖	✅ All tests are passing Nice one! All 9908 tests are passing. (There are 983 skipped tests not included in that total)

Generated by 🚫 dangerJS against 137838d

garymathews

CR: PASS

Finally got rid of TitaniumBlob.java, much better named now 😃

garymathews · 2020-10-02T04:37:29Z

tests/Resources/ti.filesystem.file.test.js

 		});

 		it.androidAndIosBroken('file:// relative path', () => {
 			// FIXME: Android seems to basically forcibly place '/' in front of paths not beginning with '..' or '/'
 			// FIXME: iOS does not seem to try and resolve relative paths for file:// URIs
 			const file = Ti.Filesystem.getFile('file://app.js'); // app.js should be relative to this file...
 			should.exist(file);
-			should(file.exists()).equal(true);
+			should(file.exists()).be.true();


NOTE: Should these tests be enabled on Android now?

This test still won't work on Android. We would have to modify TiFileFactory to check if the "file://" URL has a relative and have it use our TiResourceFile instead of a TiFile object since our APK's "assets/Resources" folder is not accessible from the file system.

But the problem here is if you set a relative path without a URL scheme like this...

Ti.Filesystem.getFile('app.js');

...then TiFileFactory defaults to the applicationDataDirectory, not resourcesDirectory like this unit test assumes. So, we have an inconsistency here.

Fixes TIMOB-28183

ssaddique · 2020-10-13T13:31:05Z

FR: Pass

Test Environment
SDK Ver: 9.2.1.GA, this PR
OS Ver: 10.15.6
Appc NPM: 5.0.0
Appc CLI: 8.1.1
Node Ver: 10.17.0
NPM Ver: 6.13.6
Java Ver: 1.8.0_162
Devices: Pixel 3a (11.0)
Emulator: Pixel 2 (4.4 - 8.1), Pixel 3 (9.0 - 10.0), Pixel 4 (11.0)

jquick-axway added 5 commits September 30, 2020 22:58

refactor(android): removed unsupported "ti.android.enablecoverage"

3518251

refactor(android): rename TitaniumBlob to TiContentFile

1a286b7

Merge branch 'master' into TIMOB-28059

577cdf5

jquick-axway added android bug improvement labels Oct 1, 2020

jquick-axway added this to the 9.3.0 milestone Oct 1, 2020

jquick-axway requested a review from garymathews October 1, 2020 07:35

build requested a review from a team October 1, 2020 08:01

Merge branch 'master' into TIMOB-28059

000a350

garymathews approved these changes Oct 2, 2020

View reviewed changes

garymathews added the in-qe-testing 🕵 label Oct 2, 2020

garymathews reviewed Oct 2, 2020

View reviewed changes

jquick-axway mentioned this pull request Oct 7, 2020

refactor(android): temp file handling #12161

Merged

ssaddique and others added 7 commits October 7, 2020 16:39

Merge branch 'master' into TIMOB-28059

b032fd4

Merge branch 'master' into TIMOB-28059

94a8916

Merge branch 'master' into TIMOB-28059

0182810

Merge branch 'master' into TIMOB-28059

de7b54e

chore(android): media capture improvements for TIMOB-28059

b8e5f15

feat(android): add has/requestPhotoGalleryPermissions() support

5d0a7b4

Fixes TIMOB-28183

Merged

89c5a5f

build added the docs label Oct 10, 2020

ssaddique and others added 3 commits October 12, 2020 15:53

Merge branch 'master' into TIMOB-28059

6c8023a

test: fix linting issue in "ti.media.test.js"

c7f900c

chore(android): create pictures/movies dir if needed

137838d

ssaddique merged commit 9b42601 into tidev:master Oct 13, 2020

m1ga mentioned this pull request Mar 5, 2021

TitaniumBlob -> TiContentFile NetrisTV/ti.exoplayer#12

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

refactor(android): media/file APIs to use scoped storage #12143

refactor(android): media/file APIs to use scoped storage #12143

jquick-axway commented Oct 1, 2020 •

edited

build commented Oct 1, 2020 •

edited

garymathews left a comment •

edited

garymathews Oct 2, 2020

jquick-axway Oct 2, 2020

ssaddique commented Oct 13, 2020 •

edited

refactor(android): media/file APIs to use scoped storage #12143

refactor(android): media/file APIs to use scoped storage #12143

Conversation

jquick-axway commented Oct 1, 2020 • edited

build commented Oct 1, 2020 • edited

garymathews left a comment • edited

Choose a reason for hiding this comment

garymathews Oct 2, 2020

Choose a reason for hiding this comment

jquick-axway Oct 2, 2020

Choose a reason for hiding this comment

ssaddique commented Oct 13, 2020 • edited

jquick-axway commented Oct 1, 2020 •

edited

build commented Oct 1, 2020 •

edited

garymathews left a comment •

edited

ssaddique commented Oct 13, 2020 •

edited