Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(android): update kotlin language support to 1.4.0 #12154

Merged
merged 3 commits into from Oct 9, 2020

Conversation

jquick-axway
Copy link
Contributor

JIRA:
https://jira.appcelerator.org/browse/TIMOB-28102

Summary:
Updates module builds to use kotlin language 1.4.0.
https://android-developers.googleblog.com/2020/08/new-language-features-and-more-in.html

Test:

  1. Download ti.kotlin.zip attached to TIMOB-25896.
  2. Unzip it.
  3. Copy the below TiKotlin14.kt file to folder: ./ti.kotlin/android/src/ti/kotlin
  4. CD to directory: ./ti.kotlin/android
  5. Run: appc run -p android
  6. Verify app builds and runs successfully.

./ti.kotlin/android/src/ti/kotlin/TiKotlin14.kt

package ti.kotlin;

class TiKotlin14
{
	fun test()
	{
		val colorList = listOf(
			"red",
			"green",
			"blue",  // Trailing comma support requires kotlin 1.4
		);
	}
}

@build
Copy link
Contributor

build commented Oct 3, 2020

Fails
🚫 Tests have failed, see below for more information.
Messages
📖

💾 Here's the generated SDK zipfile.

📖 ✊ The commits in this PR match our conventions! Feel free to Rebase and Merge this PR when ready.
📖 ❌ 2 tests have failed There are 2 tests failing and 982 skipped out of 10823 total tests.

Tests:

ClassnameNameTimeError
android.emulator.Titanium.UI.ImageViewimage error event (11)5.004
Error: timeout of 5000ms exceeded
at Titanium.<anonymous> (/ti-mocha.js:6535:53723)
ios.macos.Titanium.UI.iOS.CollisionBehavior.exampleworks (10.15.4)15.067
Error: timeout of 15000ms exceeded
file:///Users/build/jenkins/workspace/ium-sdk_titanium_mobile_PR-12154/tmp/mocha/build/iphone/build/Products/Debug-maccatalyst/mocha.app/Contents/Resources/ti-mocha.js:4326:27

Generated by 🚫 dangerJS against 42576e7

@ssjsamir ssjsamir self-requested a review October 9, 2020 14:39
Copy link
Contributor

@ssjsamir ssjsamir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FR Passed: Tested using the steps mentioned in the description. Able to build kotlin module with 1.4.0 changes.

Test Environment

MacOS Big Sur: 11.0 Beta 8
Java Version: 1.8.0_242
Android NDK: 21.3.6528147
Node.js: 12.18.1
""NPM":"5.0.0","CLI":"8.1.1""
Pixel XL Sim (10.0)

@sgtcoolguy sgtcoolguy merged commit 5dc0872 into tidev:master Oct 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants