New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TIMOB-7224] Added the TextBox base class and the TextArea and Textfield implementations #1216
Conversation
type: Number | ||
- autocorrect |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be "- name: autocorrect"
value: UI.INPUT_BORDERSTYLE_NONE, | ||
set: function(value, oldValue) { | ||
var n = this.domNode, | ||
s = "TiUITextFieldBorderStyle"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can move these in the if statement for performance reasons.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It won't affect performance. If you move the var inside the if, it still allocates the variables. Touching the DOM is what's affects the performance.
…d code that detaches the TextField form.
Code reviewed and tested. Request accepted |
Reviewed doc, validated & ran docgen. APPROVED. |
[TIMOB-7224] Added the TextBox base class and the TextArea and Textfield implementations
No description provided.