Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(android): openPhotoGallery() crashes when canceled as of 9.1.0 #12165

Merged
merged 2 commits into from Oct 8, 2020
Merged

fix(android): openPhotoGallery() crashes when canceled as of 9.1.0 #12165

merged 2 commits into from Oct 8, 2020

Conversation

jquick-axway
Copy link
Contributor

JIRA:
https://jira.appcelerator.org/browse/TIMOB-28178

Test:

  1. Build and run PhotoVideoSelectTest.js attached to TIMOB-28178 on Android.
  2. When dialog is shown, tap on "Photo".
  3. Back out of the app.
  4. Verify app does not crash and you return to an empty window.
  5. Exit and relaunch the app.
  6. Select "Photo" from the dialog.
  7. Select an image from the gallery.
  8. Verify Titanium app displays that photo.
  9. Exit and relaunch the app.
  10. Select "Video" from the dialog.
  11. Select a video from the gallery.
  12. Verify Titanium app plays the selected video.

@jquick-axway
fix(android): openPhotoGallery() crashes when canceled
d56f734 
- Regression introduced in 9.1.0

Fixes TIMOB-28178
@jquick-axway jquick-axway added this to the 9.3.0 milestone Oct 8, 2020
@build build requested a review from a team October 8, 2020 01:23
@build
Copy link
Contributor

build commented Oct 8, 2020 •
edited

Messages
📖 👍 Hey!, You deleted more code than you added. That's awesome!
📖

💾 Here's the generated SDK zipfile.
📖 ✊ The commits in this PR match our conventions! Feel free to Rebase and Merge this PR when ready.
📖

✅ All tests are passing
Nice one! All 9966 tests are passing.
(There are 984 skipped tests not included in that total)

Generated by 🚫 dangerJS against adbdeea

@ssekhri
Copy link

ssekhri commented Oct 8, 2020

FR Passed
Verified on:
Mac OS: 10.15.4
SDK: 9.3.0.v20201007180413
Appc CLI: 8.1.1
JDK: 11.0.4
Node: 10.17.0
Studio: 6.0.0.202005141803
Device: Nexus4(v5.1.1) device, Pixel 3 XL(v11.0) emulator, Pixel 3(v10.0) emulator

@ssekhri ssekhri merged commit 0e284e5 into tidev:master Oct 8, 2020
AndreaVitale pushed a commit to AndreaVitale/titanium_mobile that referenced this pull request Oct 14, 2020
@jquick-axway @AndreaVitale
fix(android): openPhotoGallery() crashes when canceled (tidev#12165)
abca85f 
- Regression introduced in 9.1.0

Fixes TIMOB-28178

Co-authored-by: ssekhri <ssekhri@axway.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgtcoolguy sgtcoolguy sgtcoolguy approved these changes

@garymathews garymathews Awaiting requested review from garymathews

Assignees
No one assigned
Labels
android bug in-qe-testing 🕵 no tests
Projects
None yet
Milestone
9.3.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jquick-axway @build @ssekhri @sgtcoolguy