Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(mac): generate missing macOS asset catalog icons #12172

Merged
merged 4 commits into from Oct 23, 2020
Merged

fix(mac): generate missing macOS asset catalog icons #12172

merged 4 commits into from Oct 23, 2020

Conversation

hansemannn
Copy link
Collaborator

@rohidjetha
Copy link
Contributor

Just tried it and it's working great!

@build build added this to the 9.3.0 milestone Oct 9, 2020
@build
Copy link
Contributor

build commented Oct 9, 2020 •
edited

Warnings
⚠️ This PR has milestone set to 9.2.2, but the version defined in package.json is 9.3.0 Please either: - Update the milestone on the PR - Update the version in package.json - Hold the PR to be merged later after a release and version bump on this branch
Messages
📖 🎉 Another contribution from our awesome community member, hansemannn! Thanks again for helping us make Titanium SDK better. 👍
📖 ✊ The commits in this PR match our conventions! Feel free to Rebase and Merge this PR when ready.
📖

✅ All tests are passing
Nice one! All 9527 tests are passing.
(There are 834 skipped tests not included in that total)

Generated by 🚫 dangerJS against c6af381

sgtcoolguy
sgtcoolguy approved these changes Oct 9, 2020
View reviewed changes
Copy link
Contributor

@sgtcoolguy sgtcoolguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hansemannn @vijaysingh-axway
fix: add mac-app-store target
d60bff4 
Co-authored-by: Vijay Vikram Singh <vsingh@axway.com>
@sgtcoolguy sgtcoolguy modified the milestones: 9.3.0, 9.2.2 Oct 16, 2020
@ssekhri
Copy link

ssekhri commented Oct 23, 2020

FR Passed. MacOS icons added when build for target as 'macos' or 'dist-macappstore'.

Verified on:
Mac OS: 10.15.4
SDK: 9.3.0.v20201023101805
Appc CLI: 8.1.1
JDK: 11.0.4
Node: 10.17.0
Xcode: 12.0.1

@sgtcoolguy sgtcoolguy merged commit 503e366 into tidev:master Oct 23, 2020
@build build mentioned this pull request Oct 23, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vijaysingh-axway vijaysingh-axway vijaysingh-axway left review comments

@sgtcoolguy sgtcoolguy sgtcoolguy approved these changes

Assignees
No one assigned
Labels
cli 📟 community 🔥 improvement in-qe-testing 🕵 ios no tests
Projects
None yet
Milestone
9.2.2
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@hansemannn @rohidjetha @build @ssekhri @sgtcoolguy @vijaysingh-axway