fix(android): TabGroup without badge crashes when using AppCompat theme as of 9.3.0 #12175
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA:
https://jira.appcelerator.org/browse/TIMOB-28189
Summary:
TabGroup
should only throw an exception if usingTheme.AppCompat
and you also assign the "badge" property. This is because badges requires an app to use theTheme.MaterialComponents
theme (which is the default). It should NOT throw an exception if the "badge" property is NOT set for backward compatibility, which is the regression this PR fixes.Test:
<application/>
entry into the "tiapp.xml".app.js
to the project.tabGroupSettings.style = Ti.UI.Android.TABS_STYLE_BOTTOM_NAVIGATION;
tabGroup.tabs[1].badge = "5";
The style on this component requires your app theme to be Theme.MaterialComponents
tabGroupSettings.style = Ti.UI.Android.TABS_STYLE_BOTTOM_NAVIGATION;
The style on this component requires your app theme to be Theme.MaterialComponents
<application/>
XML element.5
.tabGroupSettings.style = Ti.UI.Android.TABS_STYLE_BOTTOM_NAVIGATION;
5
.tiapp.xml
app.js