Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update android to use v8 8.6.395.10 #12186

Merged
merged 1 commit into from Oct 19, 2020

Conversation

sgtcoolguy
Copy link
Contributor

👆🏻

@build
Copy link
Contributor

build commented Oct 16, 2020

Fails
🚫 Tests have failed, see below for more information.
Warnings
⚠️ There is no linked JIRA ticket in the PR body. Please include the URL of the relevant JIRA ticket. If you need to, you may file a ticket on JIRA
Messages
📖 👍 Hey!, You deleted more code than you added. That's awesome!
📖

💾 Here's the generated SDK zipfile.

📖 ✊ The commits in this PR match our conventions! Feel free to Rebase and Merge this PR when ready.
📖 ❌ 1 tests have failed There are 1 tests failing and 988 skipped out of 11785 total tests.

Tests:

ClassnameNameTimeError
ios.ipad.Titanium.UI.WebViewuserAgent (14.0)59.999
Error: timeout of 60000ms exceeded
file:///Users/build/Library/Developer/CoreSimulator/Devices/AEB0AAF4-FED7-4BF5-8DDC-233DE4C6A1FF/data/Containers/Bundle/Application/D30E93F8-D0B3-4C6F-85B0-205E2862BC21/mocha.app/ti-mocha.js:4290:32

Generated by 🚫 dangerJS against afc9d78

Copy link
Contributor

@garymathews garymathews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@sgtcoolguy
Copy link
Contributor Author

Nothing to test here, really. So long as the SDK builds, the test app builds and passes tests and native modules can still be used without compilation changes (which the test app does test). So I'm gonna merge without formal QE FR.

@sgtcoolguy sgtcoolguy merged commit ebc3800 into tidev:master Oct 19, 2020
@sgtcoolguy sgtcoolguy deleted the v8-8.6 branch October 19, 2020 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants