New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(angular): declare missing nodejs namespace for zone.js #12199
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Tested changes locally and able to build
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FR Passed: Able to now run the angular template on MAC. (Still need to test windows).
Test Environment
MacOS Big Sur: 11.0 Beta 9
Xcode: 12.2 Beta
Java Version: 1.8.0_242
Android NDK: 21.3.6528147
Node.js: 12.18.1
""NPM":"5.0.0","CLI":"8.1.1""
iphone 8 (14.0 SIm)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FR Passed, Able to build the template on Windows using appc new --ng
Test Environment
Name = Microsoft Windows 10 Pro
Version = 10.0.18363. All Rights Reserved.
Architecture = 64bit
# CPUs = 16
Memory = 63.9GB
Node.js
Node.js Version = 12.16.1
npm Version = 6.13.4
Appcelerator CLI
Installer = 5.0.0
Core Package = 8.1.1
Titanium CLI
CLI Version = 5.2.5
node-appc Version = 1.1.1
Java Development Kit
Version = 10.0.1_10
JIRA: https://jira.appcelerator.org/browse/TIMOB-28200