Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(angular): declare missing nodejs namespace for zone.js #12199

Merged
merged 2 commits into from Oct 22, 2020

Conversation

janvennemann
Copy link
Contributor

@build
Copy link
Contributor

build commented Oct 21, 2020

Messages
📖

💾 Here's the generated SDK zipfile.

📖 ✊ The commits in this PR match our conventions! Feel free to Rebase and Merge this PR when ready.
📖

✅ All tests are passing
Nice one! All 11816 tests are passing.
(There are 1057 skipped tests not included in that total)

Generated by 🚫 dangerJS against 481fd30

Copy link
Collaborator

@ewanharris ewanharris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Tested changes locally and able to build

Copy link
Contributor

@ssjsamir ssjsamir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FR Passed: Able to now run the angular template on MAC. (Still need to test windows).

Test Environment

MacOS Big Sur: 11.0 Beta 9
Xcode: 12.2 Beta
Java Version: 1.8.0_242
Android NDK: 21.3.6528147
Node.js: 12.18.1
""NPM":"5.0.0","CLI":"8.1.1""
iphone 8 (14.0 SIm)

@ssjsamir ssjsamir self-requested a review October 22, 2020 16:28
Copy link
Contributor

@ssjsamir ssjsamir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FR Passed, Able to build the template on Windows using appc new --ng

Test Environment


Name                        = Microsoft Windows 10 Pro
Version                     = 10.0.18363.  All Rights Reserved.
Architecture                = 64bit
# CPUs                      = 16
Memory                      = 63.9GB
 
Node.js
Node.js Version             = 12.16.1
npm Version                 = 6.13.4
 
Appcelerator CLI
Installer                   = 5.0.0
Core Package                = 8.1.1
 
Titanium CLI
CLI Version                 = 5.2.5
node-appc Version           = 1.1.1
 
Java Development Kit
Version                     = 10.0.1_10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants