Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: always load aca module first on startup #12205

Merged
merged 3 commits into from Oct 26, 2020

Conversation

garymathews
Copy link
Contributor

  • Amend ti.main.js to always load Axway Crash Analytics module first on startup
TEST CASE
  • Make sure Titanium application runs without ACA added.
  • Make sure Titanium application runs with ACA added and is able to log crashes.

JIRA Ticket

@build
Copy link
Contributor

build commented Oct 22, 2020

Fails
🚫 Tests have failed, see below for more information.
Messages
📖

💾 Here's the generated SDK zipfile.

📖 ✊ The commits in this PR match our conventions! Feel free to Rebase and Merge this PR when ready.
📖 ❌ 1 tests have failed There are 1 tests failing and 1066 skipped out of 12873 total tests.

Tests:

ClassnameNameTimeError
ios.macos.Titanium.UI.iOS.CollisionBehavior.exampleworks (10.15.4)15.02
Error: timeout of 15000ms exceeded
file:///Users/build/jenkins/workspace/ium-sdk_titanium_mobile_PR-12205/tmp/mocha/build/iphone/build/Products/Debug-maccatalyst/mocha.app/Contents/Resources/ti-mocha.js:4326:27

Generated by 🚫 dangerJS against c976fff

Copy link
Contributor

@jquick-axway jquick-axway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: Pass

@jquick-axway
Copy link
Contributor

We should be able to test it like this...

  1. Add the below "my.bootstrap.js" file next to the "app.js".
  2. Make sure app is setup for ACA.
  3. Build and run on Android.
  4. Verify app crashes on startup
  5. Verify ACA logs the "My boostrap crash" on our dashboard website.

./Resources/my.bootstrap.js

throw new Error('My bootstrap crash.');

@lokeshchdhry
Copy link
Contributor

FR Passed.
The my.bootstrap.js test works as expected.
An app with & without ACA works as expected.

Studio Ver: 6.0.0.202005141803
SDK Ver: 9.3.0 local build
OS Ver: 10.15.5
Xcode Ver: Xcode 12.0.1
Appc NPM: 5.0.0
Appc CLI: 8.1.1
Daemon Ver: 3.2.0
Ti CLI Ver: 5.2.5
Alloy Ver: 1.15.2
Node Ver: 12.13.1
NPM Ver: 6.14.7
Java Ver: 11.0.6
Android Devices: ⇨ google Pixel (Android 10)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants