Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ios): fire blur event when TabGroup focus is removed #12207

Merged
merged 2 commits into from Nov 5, 2020

Conversation

vijaysingh-axway
Copy link
Contributor

@vijaysingh-axway vijaysingh-axway commented Oct 23, 2020

@build build added this to the 9.3.0 milestone Oct 23, 2020
@build build requested a review from a team October 23, 2020 01:19
@build
Copy link
Contributor

build commented Oct 23, 2020

Messages
📖

💾 Here's the generated SDK zipfile.

📖 ✊ The commits in this PR match our conventions! Feel free to Rebase and Merge this PR when ready.
📖

✅ All tests are passing
Nice one! All 12883 tests are passing.
(There are 1079 skipped tests not included in that total)

Generated by 🚫 dangerJS against 0679643

@vijaysingh-axway vijaysingh-axway modified the milestones: 9.3.0, 10.0.0 Oct 27, 2020
Copy link
Contributor

@ssjsamir ssjsamir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FR Passed: Tested using the following test case:

var basewin = Ti.UI.createWindow({
backgroundColor : 'white',
layout : 'vertical'
});
 
var baseWinBtn = Ti.UI.createButton({
title : 'Push next window (tab.open(win))',
top : 60
});
basewin.add(baseWinBtn);
 
 
var baseWinBtn2 = Ti.UI.createButton({
title : 'Open another window (win.open())',
top : 120
});
basewin.add(baseWinBtn2);
 
var baseWinBtn3 = Ti.UI.createButton({
title : 'Show Alert',
top : 180
});
basewin.add(baseWinBtn3);
 
baseWinBtn.addEventListener('click', function() {
var indWin = Ti.UI.createWindow({
backgroundColor : 'red'
});
 
tab.open(indWin);
 
var alertBtn = Ti.UI.createButton({
top: 60,
title :'click to get alert'
});
alertBtn.addEventListener('click',function(){
Ti.UI.createAlertDialog({
title : "test",
message : "test msg",
buttonNames : ['OK']
}).show();
});
indWin.add(alertBtn);
 
var closeBtn = Ti.UI.createButton({
top: 120,
title :'Close Window'
});
closeBtn.addEventListener('click',function(){
tab.close(indWin);
});
indWin.add(closeBtn);
 
});
 
 
baseWinBtn2.addEventListener('click', function() {
var indWin = Ti.UI.createWindow({
backgroundColor : 'red'
});
 
indWin.open(); //{modal: true, animation: true}
 
var closeBtn = Ti.UI.createButton({
title :'Close button'
});
closeBtn.addEventListener('click',function(){
indWin.close();
});
indWin.add(closeBtn);
});
 
baseWinBtn3.addEventListener('click', function() {
Ti.UI.createAlertDialog({
title : "test",
message : "test msg",
buttonNames : ['OK']
}).show();
});
 
var tabGroup = Ti.UI.createTabGroup({
title : '',
titleColor : "#bbb",
tintColor : "#bbb",
navBarHidden : true
});
var tab = Ti.UI.createTab({
title : 'tab1',
window : basewin
});
tabGroup.addTab(tab);
var tab2 = Ti.UI.createTab({
title : 'tab2',
window : Ti.UI.createWindow({backgroundColor : 'white'})
});
tabGroup.addTab(tab2);
tabGroup.open();
tabGroup.addEventListener('focus',function(e){
Ti.API.info('in tabgroup focus');
});
 
tabGroup.addEventListener('blur',function(e){
Ti.API.info('in tabgroup blur');
});

Test Environment

MacOS Big Sur: 11.0 Beta 9
Xcode: 12.2 Beta
Java Version: 1.8.0_242
Android NDK: 21.3.6528147
Node.js: 12.18.1
""NPM":"5.0.0","CLI":"8.1.1""
iphone 11 (14.2) Sim

@sgtcoolguy sgtcoolguy modified the milestones: 10.0.0, 9.3.0 Nov 5, 2020
@sgtcoolguy sgtcoolguy merged commit 5fa704d into tidev:master Nov 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants