New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(android): openPhotoGallery() crash selecting multiple files as of 9.1.0 #12212
Conversation
Fixes TIMOB-28193
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CR: PASS
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jquick-axway On step 10 after clicking on the 3rd/4th photo the image is not displayed, only the first two images clicked on are displayed.
Test Environment
MacOS Big Sur: 11.0 Beta 9
Xcode: 12.2 Beta
Java Version: 1.8.0_242
Android NDK: 21.3.6528147
Node.js: 12.18.1
""NPM":"5.0.0","CLI":"8.1.1""
PIXEL XL API 29
PIXEL XL device (10.0)
@ssjsamir , I can't reproduce the issue you're seeing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jquick-axway This issue is also seen on 9.0.3.GA but it looks like the fix in question for this PR is working as intended and in that case I am going to pass this FR.
A user may still run into the following issues:
https://jira.appcelerator.org/browse/TIMOB-24379 (Android: Image Views not releasing memory, resulting in crash)
https://jira.appcelerator.org/browse/TIMOB-24528 (Fails to load images that exceed GPU max texture size)
Test Environment
MacOS Big Sur: 11.0 Beta 9
Xcode: 12.2 Beta
Java Version: 1.8.0_242
Android NDK: 21.3.6528147
Node.js: 12.18.1
""NPM":"5.0.0","CLI":"8.1.1""
PIXEL XL API 29
PIXEL XL device (10.0)
The backport to
Check the run for full details # Fetch latest updates from GitHub
git fetch
# Check out the target branch
git checkout 9_2_X
# Make sure it's up to date
git pull
# Check out your branch
git checkout -b backport-12212-to-9_2_X
# Apply the commits from the PR
curl -s https://github.com/appcelerator/titanium_mobile/commit/cfe0e1c592aef034c82cdc16dbac359d1fd8a7ed.patch | git am -3 --ignore-whitespace
# Push it to GitHub
git push --set-upstream origin backport-12212-to-9_2_X Then, create a pull request where the |
JIRA:
https://jira.appcelerator.org/browse/TIMOB-28193
Summary:
Ti.Media.openPhotoGallery()
might crash when selecting multiple photos and/or videos.e.media.file
property to return aTi.Filesystem.File
object forcontent://
URLs.Test:
PhotoVideoMultiselectTest.js
attached to TIMOB-28193.