Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ios): update APSAnalytics #12220

Merged
merged 2 commits into from Oct 27, 2020
Merged

Conversation

garymathews
Copy link
Contributor

NOTE: Grabbed this from the Jenkins build, not sure why the Info.plist is different than before?

TIMOB-28174

@garymathews garymathews added this to the 9.2.2 milestone Oct 26, 2020
@build build requested a review from a team October 26, 2020 21:39
@build
Copy link
Contributor

build commented Oct 26, 2020

Fails
🚫

Test suite crashed on iOS simulator. Please see the crash log for more details.

Warnings
⚠️ This PR has milestone set to 9.2.2, but the version defined in package.json is 9.3.0 Please either: - Update the milestone on the PR - Update the version in package.json - Hold the PR to be merged later after a release and version bump on this branch
Messages
📖 ✊ The commits in this PR match our conventions! Feel free to Rebase and Merge this PR when ready.
📖

✅ All tests are passing
Nice one! All 5165 tests are passing.
(There are 476 skipped tests not included in that total)

Generated by 🚫 dangerJS against 2c05f44

Copy link
Contributor

@vijaysingh-axway vijaysingh-axway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR passed.

@sgtcoolguy
Copy link
Contributor

Info.plist just changed the ordering of the targets internally in the XML. I don't know why it did, but it's effectively equivalent to before.

@ssjsamir ssjsamir self-requested a review October 27, 2020 15:33
Copy link
Contributor

@ssjsamir ssjsamir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FR Passed, no longer getting an exception when a payload is being constructed. Tested using the test case from https://jira.appcelerator.org/browse/TIMOB-28174.

Test Environment

MacOS Big Sur: 11.0 Beta 9
Xcode: 12.2 Beta
Java Version: 1.8.0_242
Android NDK: 21.3.6528147
Node.js: 12.18.1
""NPM":"5.0.0","CLI":"8.1.1""
Iphone 8 (14.2)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants