Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ios): fix default value of property pictureInPictureEnabled #12239

Merged
merged 4 commits into from Nov 3, 2020

Conversation

vijaysingh-axway
Copy link
Contributor

@vijaysingh-axway vijaysingh-axway commented Nov 2, 2020

https://jira.appcelerator.org/browse/TIMOB-28221

This PR is to fix iOS related issue found in PR #12231 .

@build
Copy link
Contributor

build commented Nov 2, 2020

Messages
📖

💾 Here's the generated SDK zipfile.

📖 ✊ The commits in this PR match our conventions! Feel free to Rebase and Merge this PR when ready.
📖

✅ All tests are passing
Nice one! All 11954 tests are passing.
(There are 971 skipped tests not included in that total)

Generated by 🚫 dangerJS against 66d0931

@@ -576,6 +576,7 @@ properties:
summary: The type of media in the player's current item first track.
exclude-platforms: [android]
type: String
permission: read-only
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the related unit test should be modified to assert the property is read-only

@lokeshchdhry
Copy link
Contributor

FR Passed.

@sgtcoolguy sgtcoolguy merged commit ba7e5aa into tidev:master Nov 3, 2020
@build
Copy link
Contributor

build commented Nov 3, 2020

The backport to 9_2_X failed:

The process 'git' failed with exit code 128

Check the run for full details
To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Check out the target branch
git checkout 9_2_X
# Make sure it's up to date
git pull
# Check out your branch
git checkout -b backport-12239-to-9_2_X
# Apply the commits from the PR
curl -s https://github.com/appcelerator/titanium_mobile/commit/8c8600cea5c00246b4f41be4ce522ed460219ac1.patch | git am -3 --ignore-whitespace
curl -s https://github.com/appcelerator/titanium_mobile/commit/6686addd651ffdfd31e04f5a8ba7742e1d85862f.patch | git am -3 --ignore-whitespace
# Push it to GitHub
git push --set-upstream origin backport-12239-to-9_2_X

Then, create a pull request where the base branch is 9_2_X and the compare/head branch is backport-12239-to-9_2_X.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants