Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(android): tintColor on bottom navigation #12242

Merged
merged 10 commits into from Nov 6, 2020

Conversation

garymathews
Copy link
Contributor

  • Allow color filter to be set on Drawable
TEST CASE
const tabGroup = Ti.UI.createTabGroup({
    style: Ti.UI.Android.TABS_STYLE_BOTTOM_NAVIGATION
});
const tabWin_home = Ti.UI.createWindow({
    title: 'Home',
    backgroundColor: 'gray'
});
const tab_home = Ti.UI.createTab({
    icon: 'KS_nav_ui.png',
    title: 'Home',
    titleColor: 'red',
    activeTitleColor: 'blue',
    window: tabWin_home
});
const tabWin_chat = Ti.UI.createWindow({
    title: 'Chat',
    backgroundColor: 'gray'
});
const tab_chat = Ti.UI.createTab({
    icon: 'KS_nav_views.png',
    title: 'Chat',
    titleColor: 'red',
    activeTitleColor: 'blue',
    window: tabWin_chat
});

tabGroup.addTab(tab_home);
tabGroup.addTab(tab_chat);
tabGroup.open();

JIRA Ticket

@garymathews garymathews added this to the 9.3.0 milestone Nov 3, 2020
@build build requested a review from a team November 3, 2020 19:29
@build
Copy link
Contributor

build commented Nov 3, 2020

Messages
📖 👍 Hey!, You deleted more code than you added. That's awesome!
📖

💾 Here's the generated SDK zipfile.

📖 ✊ The commits in this PR match our conventions! Feel free to Rebase and Merge this PR when ready.
📖

✅ All tests are passing
Nice one! All 13813 tests are passing.
(There are 979 skipped tests not included in that total)

Generated by 🚫 dangerJS against 01f515d

Copy link
Contributor

@jquick-axway jquick-axway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: Pass

@build build added the docs label Nov 4, 2020
@lokeshchdhry
Copy link
Contributor

FR Passed.

@sgtcoolguy sgtcoolguy merged commit f640850 into tidev:master Nov 6, 2020
drauggres pushed a commit to NetrisTV/titanium_mobile that referenced this pull request Feb 3, 2021
Fixes TIMOB-28220

(cherry picked from commit f640850)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants