Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ios): fix crash for dateTimeColor property on mac #12249

Merged
merged 2 commits into from Nov 5, 2020
Merged

fix(ios): fix crash for dateTimeColor property on mac #12249

merged 2 commits into from Nov 5, 2020

Conversation

vijaysingh-axway
Copy link
Contributor

@vijaysingh-axway vijaysingh-axway commented Nov 4, 2020 •
edited

JIRA: https://jira.appcelerator.org/browse/TIMOB-28227

Unit test is already there. It should not crash.

@build build added this to the 9.3.0 milestone Nov 4, 2020
@build build requested review from a team November 4, 2020 20:18
@build
Copy link
Contributor

build commented Nov 4, 2020 •
edited

Fails
🚫

Test suite crashed on iOS simulator. Please see the crash log for more details.
Messages
📖 ✊ The commits in this PR match our conventions! Feel free to Rebase and Merge this PR when ready.
📖

✅ All tests are passing
Nice one! All 9167 tests are passing.
(There are 703 skipped tests not included in that total)

Generated by 🚫 dangerJS against 4443bbf

@ssekhri
Copy link

ssekhri commented Nov 5, 2020

FR Passed.
Verified on:
Mac OS: 10.15.4
SDK: 9.3.0.v20201104114740
Appc CLI: 8.1.1
JDK: 11.0.6
Node: 12.16.1
Xcode: 12.0.1

@sgtcoolguy sgtcoolguy merged commit fc772ee into tidev:master Nov 5, 2020
@build build mentioned this pull request Nov 5, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgtcoolguy sgtcoolguy sgtcoolguy approved these changes

Assignees
No one assigned
Labels
bug docs in-qe-testing 🕵 ios no tests
Projects
None yet
Milestone
9.3.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@vijaysingh-axway @build @ssekhri @sgtcoolguy