New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ios): fix a couple of memory leaks #12254
Conversation
|
} | ||
return [[TiColor alloc] initWithColor:UIColor.blackColor name:@"black"]; | ||
return [[[TiColor alloc] initWithColor:UIColor.blackColor name:@"black"] autorelease]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This actually causes some huge leaks, because it's used like a few hundred times by larger apps
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CR passed!
JIRA: https://jira.appcelerator.org/browse/TIMOB-28232
There are roughly 15 more. Would be great if someone from the core team could assist here.