Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(android): java deployFromZip() and deployFromAssets() #12281

Merged
merged 1 commit into from Nov 21, 2020

Conversation

jquick-axway
Copy link
Contributor

@jquick-axway jquick-axway commented Nov 20, 2020

JIRA:
https://jira.appcelerator.org/browse/TIMOB-28246

Summary:

Test:
I've already tested the Java code by hand via the Android Studio debugger. I think we should skip QE and merge it once code reviewed.

- Regression caused by TIMOB-28246 change.
- Nobody uses these methods.
@build
Copy link
Contributor

build commented Nov 20, 2020

Warnings
⚠️ This PR has milestone set to 9.3.0, but the version defined in package.json is 10.0.0 Please either: - Update the milestone on the PR - Update the version in package.json - Hold the PR to be merged later after a release and version bump on this branch
Messages
📖

💾 Here's the generated SDK zipfile.

📖 ✊ The commits in this PR match our conventions! Feel free to Rebase and Merge this PR when ready.
📖

✅ All tests are passing
Nice one! All 12060 tests are passing.
(There are 900 skipped tests not included in that total)

Generated by 🚫 dangerJS against 09db253

Copy link
Contributor

@garymathews garymathews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: PASS

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants