Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(android): add missing options to Intl.DateTimeFormat.resolvedOptions() #12282

Merged
merged 4 commits into from Jan 7, 2021

Conversation

jquick-axway
Copy link
Contributor

@jquick-axway jquick-axway commented Nov 21, 2020

JIRA:
https://jira.appcelerator.org/browse/TIMOB-28251

Summary:

  • Adds missing properties returned by Intl.DateTimeFormat.resolvedOptions().
  • Note that this returns "timeZone" which is the only API providing this info on both Android and iOS.

Test:

  1. Build and run the below on Android.
  2. Verify an alert dialog appears displaying the device's assigned time zone.
    2.1. Must match a "TZ database name" shown here.
    2.2. Ex: Will be "America/Los_Angeles" for all of California USA.
    2.3. Ex: Will be "Europe/Dublin" for Dublin Ireland.
alert("TimeZone: " + Intl.DateTimeFormat().resolvedOptions().timeZone);

@build
Copy link
Contributor

build commented Nov 21, 2020

Warnings
⚠️ This PR has milestone set to 9.3.1, but the version defined in package.json is 10.0.0 Please either: - Update the milestone on the PR - Update the version in package.json - Hold the PR to be merged later after a release and version bump on this branch
⚠️

Commit 5f623c995d000b4ad46bab54a76e6af87ce6e305 has a message "android(feat): add DateTimeFormat.resolvedOptions() timeZone

Fixes TIMOB-28251" giving 1 errors:

  • type must be one of [build, chore, ci, docs, feat, fix, perf, refactor, revert, style, test]
Messages
📖

🚨 This PR has one or more commits with warnings/errors for commit messages not matching our configuration. You may want to squash merge this PR and edit the message to match our conventions, or ask the original developer to modify their history.

📖

✅ All tests are passing
Nice one! All 13501 tests are passing.
(There are 902 skipped tests not included in that total)

Generated by 🚫 dangerJS against 474907f

@jquick-axway jquick-axway changed the title android(feat): add Intl.DateTimeFormat.resolvedOptions() timeZone support feat(android): add Intl.DateTimeFormat.resolvedOptions() timeZone support Nov 21, 2020
@jquick-axway jquick-axway changed the title feat(android): add Intl.DateTimeFormat.resolvedOptions() timeZone support feat(android): add missing options to Intl.DateTimeFormat.resolvedOptions() Dec 8, 2020
@jquick-axway jquick-axway modified the milestones: 10.0.0, 9.3.1 Dec 8, 2020
Copy link
Contributor

@garymathews garymathews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: PASS

Copy link
Contributor

@ssjsamir ssjsamir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FR Passed: Able to get correct time zone for the device using the test case above.

Test Environment
MacOS Big Sur: 11.1 Beta 1
Xcode: 12.3
Java Version: 1.8.0_242
Android NDK: 21.3.6528147
Node.js: 12.18.1
""NPM":"5.0.0","CLI":"8.1.1""
NEXUS 5X API 29 Emulator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants