Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API Removals #12292

Merged
merged 29 commits into from Jan 5, 2021
Merged

API Removals #12292

merged 29 commits into from Jan 5, 2021

Conversation

sgtcoolguy
Copy link
Contributor

JIRA: https://jira.appcelerator.org/browse/[TICKET]

Description:
This PR:

  • removes API doc entries for some APIs that have been long marked as removed in older SDK releases.
  • In a couple cases, the API was marked removed but some lingering code/impl was around and I removed it
  • Removes some APIs that have long been deprecated and updates the API docs to mark them as removed.

The commit subjects give the details as to the list of APIs affected.

@sgtcoolguy sgtcoolguy added this to the 10.0.0 milestone Nov 24, 2020
@build build requested review from a team November 24, 2020 16:24
@build
Copy link
Contributor

build commented Nov 24, 2020 •
edited

Fails
🚫 Tests have failed, see below for more information.
Warnings
⚠️ There is no linked JIRA ticket in the PR body. Please include the URL of the relevant JIRA ticket. If you need to, you may file a ticket on JIRA
Messages
📖 👍 Hey!, You deleted more code than you added. That's awesome!
📖 ✊ The commits in this PR match our conventions! Feel free to Rebase and Merge this PR when ready.
📖 ❌ 1 tests have failed There are 1 tests failing and 992 skipped out of 16250 total tests.

Tests:

ClassnameNameTimeError
ios.iphone.Titanium.UI.TabGroupadd Map.View to TabGroup (14.0.0)15.001
Error: timeout of 15000ms exceeded
file:///Users/build/Library/Developer/CoreSimulator/Devices/B15C936C-AE26-45D6-BA6B-EC640E4DAA5A/data/Containers/Bundle/Application/6283EBE6-AA6D-4955-99DF-8B0776D56495/mocha.app/ti-mocha.js:4290:32

Generated by 🚫 dangerJS against aab5b57

@sgtcoolguy sgtcoolguy marked this pull request as ready for review December 16, 2020 17:58
@sgtcoolguy
fix(ios)!: remove Ti.Media.VideoPlay#thumbnailImageAtTime() method
ba8ccbd
@sgtcoolguy
docs(api): remove entry for Ti.Media.VideoPlayer#thumbnailImageAtTime()
c35cf40
@sgtcoolguy
fix(ios)!: remove Ti.UI.orientation and #isLandscape()/#isPortrait()
adae8da
@sgtcoolguy
refactor(android): remove unused UIModule#doSetOrientation() method
66b29a7
@sgtcoolguy
docs(api): remove entry for Ti.UI.orientation property
5bd4648
@sgtcoolguy
fix(android)!: remove Ti.UI.ImageView.url property
b959ab7
@sgtcoolguy
docs(api): remove Ti.UI.ImageView.url property
c81a686
@sgtcoolguy
docs(api): remove Ti.UI.currentTab property
8a8788d
@sgtcoolguy
test: remove placeholder for removed Ti.UI.currentTab property
794a472
@sgtcoolguy
fix(ios)!: remove Ti.UI.Window.url property
6d8b78b
@sgtcoolguy
docs(api): remove Ti.UI.Window.url property
086a98e
@sgtcoolguy
docs(api): remove Ti.UI.currentWindow property
5d110fa
@sgtcoolguy
fix(ios)!: remove Ti.UI.currentWindow property
532cf62 
NOTE: This may have some impact on tab behavior and may affect modules if they rely
on TiProxy currentWindow method
@sgtcoolguy
docs(api): remove Ti.UI.ListView.rowAction event
c3debaf
@sgtcoolguy
fix(android)!: remove Ti.Android.PENDING_INTENT_* constants
472fd53
@sgtcoolguy
test(android): remove tests for Ti.Android.PENDING_INTENT_* constants
f0345d5
@sgtcoolguy
docs(api): mark Ti.Android.PENDING_INTENT_* constants removed in SDK …
ac9a724 
…10.0.0
@sgtcoolguy
docs(api): mark Ti.Media.previewImage error callback message property…
6b54239 
… removed
@sgtcoolguy
fix(android)!: remove message property from error responses used by M…
d49ca3e 
…edia module
@sgtcoolguy
refactor(android): use valueOf to generate Boolean/Integer values in …
299b56d 
…error dict
@sgtcoolguy
fix(ios)!: remove Ti.Media.Sound.error event message property
e7fb60f
@sgtcoolguy
fix(android)!: remove Ti.Media.Sound.error event message property
f2faa08
@sgtcoolguy
docs(api): mark Ti.Media.Sound.error event message property removed
956399e
@sgtcoolguy
fix(ios): report Ti.Media.VideoPlayer.error event with all typical er…
e525709 
…ror properties
@sgtcoolguy
fix(android)!: remove Ti.Media.VideoPlayer.error event message property
6cfa90d
@sgtcoolguy
docs(api): mark Ti.Media.VideoPlayer.error event message property rem…
940cfc0 
…oved
@sgtcoolguy
fix(ios)!: remove Ti.Media#hasAudioPermissions() method
a8320a2
@sgtcoolguy
docs(api): mark Ti.Media#hasAudioPermissions() method removed
dce8a4f
@sgtcoolguy
test: remove basic test for Ti.Media#hasAudioPermissions() method
aab5b57
@sgtcoolguy sgtcoolguy merged commit e256325 into tidev:master Jan 5, 2021
@sgtcoolguy sgtcoolguy deleted the removals branch January 5, 2021 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
android BREAKING CHANGES ⚠️ deprecation docs ios
Projects
None yet
Milestone
10.0.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sgtcoolguy @build