Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(android): update v8 to 8.6.395.25 #12293

Merged
merged 1 commit into from Nov 24, 2020

Conversation

garymathews
Copy link
Contributor

@garymathews garymathews commented Nov 24, 2020

JIRA Ticket

Test:

  1. Create a Classic project with the below "tiapp.xml" and "app.js".
  2. Add module ti.java.zip from TIMOB-28252 to the project.
  3. Build and run on Android.
  4. Verify the following is logged. It must be null. (The bug was it used to be an empty string.)
    @@@ type: [object]
    @@@ value: null

tiapp.xml

<ti:app>
	<modules>
		<module version="1.0.0">ti.java</module>
	</modules>
</ti:app>

app.js

var value = require("ti.java").text;
console.info("@@@ type: " + (typeof value));
console.info("@@@ value: " + value);

@build
Copy link
Contributor

build commented Nov 24, 2020

Fails
🚫

Test suite crashed on iOS simulator. Please see the crash log for more details.

Messages
📖 ✊ The commits in this PR match our conventions! Feel free to Rebase and Merge this PR when ready.
📖

✅ All tests are passing
Nice one! All 11031 tests are passing.
(There are 808 skipped tests not included in that total)

Generated by 🚫 dangerJS against 6914933

Copy link
Contributor

@jquick-axway jquick-axway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: Pass

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants