Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(android): support border for search bar #12315

Merged
merged 1 commit into from Dec 7, 2020

Conversation

garymathews
Copy link
Contributor

@garymathews garymathews commented Dec 4, 2020

  • Support border for search bars added to ListView/TableView
TEST CASE
const win = Ti.UI.createWindow();
const search = Ti.UI.createSearchBar({
    borderRadius: 8,
    borderColor: 'red',
    borderWidth: 2,
    showCancel: true
});
const tableView = Ti.UI.createTableView({
    data: [
        Ti.UI.createTableViewRow({ title: 'Row 1' }),
        Ti.UI.createTableViewRow({ title: 'Row 2' }),
        Ti.UI.createTableViewRow({ title: 'Row 3' })
    ],
    search,
    filterAttribute: 'title'
});

win.add(tableView);
win.open();

JIRA Ticket

Copy link
Contributor

@jquick-axway jquick-axway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: Pass

@build
Copy link
Contributor

build commented Dec 4, 2020

Fails
🚫 Tests have failed, see below for more information.
Messages
📖

💾 Here's the generated SDK zipfile.

📖 ✊ The commits in this PR match our conventions! Feel free to Rebase and Merge this PR when ready.
📖 ❌ 1 tests have failed There are 1 tests failing and 904 skipped out of 13692 total tests.

Tests:

ClassnameNameTimeError
android.emulator.Titanium.Geolocation#forwardGeocoder() (11)1.899
Error: expected 37.3910366 to be approximately 37.387 ±0.004
at Assertion.fail (/node_modules/should/cjs/should.js:275:13)
      at Assertion.value [as approximately] (/node_modules/should/cjs/should.js:356:9)
      at Geolocation.<anonymous> (/ti.geolocation.test.js:316:26)

Generated by 🚫 dangerJS against 02f95c2

@ssekhri
Copy link

ssekhri commented Dec 4, 2020

FR Passed.
Mac OS: 10.15.4
SDK: 10.0.0.v20201203161947
Appc CLI: 8.1.1
JDK: 11.0.6
Node: 12.16.1
Studio: 6.0.0.202005141803
Device: Pixel 3 XL(v11.0) emulator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants