New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(android): changed minSdkVersion to 21 (Android 5.0) #12316
Conversation
Tests:
|
Note that w/ appcelerator/chef-jenkins-node#8, we will now have an android-21-x86 emulator on the build nodes. We may want to consider adding in this PR forking the android tests to run on both |
@sgtcoolguy , I modified the "Jenkins" file to also test on Android 5.0. What do you think? By the way, our Android 5.0 emulator does not have enough storage space to install the APK. In my opinion, main storage should be at least 3-4 GB (I set mine to 4 GB). The emulator's default storage setting is never enough. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CR: PASS
Just waiting on Jenkins emulator space issues to be resolved.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FR Passed MinSDK version now shows 21 instead of 19 when following the test steps mentioned in the PR description.
Test Environment
MacOS Big Sur: 11.1 Beta 1
Xcode: 12.2 Beta
Java Version: 1.8.0_242
Android NDK: 21.3.6528147
Node.js: 12.18.1
""NPM":"5.0.0","CLI":"8.1.1""
N3xus 5X API 29 (emulator)
JIRA:
https://jira.appcelerator.org/browse/TIMOB-28263
Summary:
NestedScrollView
forCoordinatorLayout
support.Test:
./build/android/app
minSdkVersion
is set to21
.