Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(iOS): on removing eventlistener multiple times ourCallbackCount should not be in negative value #12339

Merged
merged 3 commits into from Dec 16, 2020
Merged

fix(iOS): on removing eventlistener multiple times ourCallbackCount should not be in negative value #12339

merged 3 commits into from Dec 16, 2020

Conversation

vijaysingh-axway
Copy link
Contributor

@build build added this to the 10.0.0 milestone Dec 11, 2020
@build build requested a review from a team December 11, 2020 21:24
@build build added the ios label Dec 11, 2020
@build
Copy link
Contributor

build commented Dec 11, 2020 •
edited

Fails
🚫 Tests have failed, see below for more information.
Warnings
⚠️

Commit 3ba4fdb92027221dfdb5bdeab90c114250f0642c has a message "fix(iOS): on removing eventlistener multiple times ourCallbackCount should not be in negative value" giving 1 errors:

  • scope must be lower-case
Messages
📖

🚨 This PR has one or more commits with warnings/errors for commit messages not matching our configuration. You may want to squash merge this PR and edit the message to match our conventions, or ask the original developer to modify their history.
📖 ❌ 18 tests have failed There are 18 tests failing and 1090 skipped out of 17398 total tests.

Tests:

ClassnameNameTimeError
android.emulator.Titanium.UI.Android.ProgressIndicatordialog indeterminant - show in different windows (11)5.005
Error: timeout of 5000ms exceeded
at Titanium.<anonymous> (/ti-mocha.js:6535:53723)
android.emulator.Titanium.UI.Clipboard.methods#hasText() returns true after setData('text/plain', value) (11)0.084
Error: expected false to be true
at Assertion.fail (/node_modules/should/cjs/should.js:275:13)
      at Assertion.value (/node_modules/should/cjs/should.js:356:9)
      at Context.<anonymous> (/ti.ui.clipboard.test.js:313:42)
      at Test.Runnable.run (/ti-mocha.js:6535:54163)
      at Runner.runTest (/ti-mocha.js:6535:58604)
      at /ti-mocha.js:6535:59445
      at next (/ti-mocha.js:6535:58013)
      at /ti-mocha.js:6535:57975
      at next (/ti-mocha.js:6535:57665)
      at /ti-mocha.js:6535:57759
android.emulator.Titanium.UI.Clipboard.methods#hasText() returns true after setData('text', value) (11)0.009
Error: expected false to be true
at Assertion.fail (/node_modules/should/cjs/should.js:275:13)
      at Assertion.value (/node_modules/should/cjs/should.js:356:9)
      at Context.<anonymous> (/ti.ui.clipboard.test.js:306:42)
      at Test.Runnable.run (/ti-mocha.js:6535:54163)
      at Runner.runTest (/ti-mocha.js:6535:58604)
      at /ti-mocha.js:6535:59445
      at next (/ti-mocha.js:6535:58013)
      at /ti-mocha.js:6535:57975
      at next (/ti-mocha.js:6535:57665)
      at /ti-mocha.js:6535:57759
android.emulator.Titanium.UI.Clipboard.methods#hasText() returns true after setText() (11)0.006
Error: expected false to be true
at Assertion.fail (/node_modules/should/cjs/should.js:275:13)
      at Assertion.value (/node_modules/should/cjs/should.js:356:9)
      at Context.<anonymous> (/ti.ui.clipboard.test.js:299:42)
      at Test.Runnable.run (/ti-mocha.js:6535:54163)
      at Runner.runTest (/ti-mocha.js:6535:58604)
      at /ti-mocha.js:6535:59445
      at next (/ti-mocha.js:6535:58013)
      at /ti-mocha.js:6535:57975
      at next (/ti-mocha.js:6535:57665)
      at /ti-mocha.js:6535:57759
android.emulator.Titanium.UI.Clipboard.methods#hasData() returns false for other mimeTypes (11)0.009
Error: expected false to be true
at Assertion.fail (/node_modules/should/cjs/should.js:275:13)
      at Assertion.value (/node_modules/should/cjs/should.js:356:9)
      at Context.<anonymous> (/ti.ui.clipboard.test.js:249:42)
      at Test.Runnable.run (/ti-mocha.js:6535:54163)
      at Runner.runTest (/ti-mocha.js:6535:58604)
      at /ti-mocha.js:6535:59445
      at next (/ti-mocha.js:6535:58013)
      at /ti-mocha.js:6535:57975
      at next (/ti-mocha.js:6535:57665)
      at /ti-mocha.js:6535:57759
android.emulator.Titanium.UI.Clipboard.methods#hasData() assumes text mimeType with no argument (11)0.01
Error: expected false to be true
at Assertion.fail (/node_modules/should/cjs/should.js:275:13)
      at Assertion.value (/node_modules/should/cjs/should.js:356:9)
      at Context.<anonymous> (/ti.ui.clipboard.test.js:237:42)
      at Test.Runnable.run (/ti-mocha.js:6535:54163)
      at Runner.runTest (/ti-mocha.js:6535:58604)
      at /ti-mocha.js:6535:59445
      at next (/ti-mocha.js:6535:58013)
      at /ti-mocha.js:6535:57975
      at next (/ti-mocha.js:6535:57665)
      at /ti-mocha.js:6535:57759
android.emulator.Titanium.UI.Clipboard.methods#getText() returns given string after setData('text/plain') (11)0.02
Error: expected null to equal 'setData'
at Assertion.fail (/node_modules/should/cjs/should.js:275:13)
      at Assertion.value (/node_modules/should/cjs/should.js:356:9)
      at Context.<anonymous> (/ti.ui.clipboard.test.js:178:35)
      at Test.Runnable.run (/ti-mocha.js:6535:54163)
      at Runner.runTest (/ti-mocha.js:6535:58604)
      at /ti-mocha.js:6535:59445
      at next (/ti-mocha.js:6535:58013)
      at /ti-mocha.js:6535:57975
      at next (/ti-mocha.js:6535:57665)
      at /ti-mocha.js:6535:57759
android.emulator.Titanium.UI.Clipboard.methods#getText() returns given string after setData('text') (11)0.007
Error: expected null to equal 'setData'
at Assertion.fail (/node_modules/should/cjs/should.js:275:13)
      at Assertion.value (/node_modules/should/cjs/should.js:356:9)
      at Context.<anonymous> (/ti.ui.clipboard.test.js:171:35)
      at Test.Runnable.run (/ti-mocha.js:6535:54163)
      at Runner.runTest (/ti-mocha.js:6535:58604)
      at /ti-mocha.js:6535:59445
      at next (/ti-mocha.js:6535:58013)
      at /ti-mocha.js:6535:57975
      at next (/ti-mocha.js:6535:57665)
      at /ti-mocha.js:6535:57759
android.emulator.Titanium.UI.Clipboard.methods#getText() returns given string after setText() (11)0.006
Error: expected null to equal 'setText'
at Assertion.fail (/node_modules/should/cjs/should.js:275:13)
      at Assertion.value (/node_modules/should/cjs/should.js:356:9)
      at Context.<anonymous> (/ti.ui.clipboard.test.js:164:35)
      at Test.Runnable.run (/ti-mocha.js:6535:54163)
      at Runner.runTest (/ti-mocha.js:6535:58604)
      at /ti-mocha.js:6535:59445
      at next (/ti-mocha.js:6535:58013)
      at /ti-mocha.js:6535:57975
      at next (/ti-mocha.js:6535:57665)
      at /ti-mocha.js:6535:57759
android.emulator.Titanium.UI.Clipboard.methods#getData() returns 'text' data type (11)0.004
Error: expected false to be true
at Assertion.fail (/node_modules/should/cjs/should.js:275:13)
      at Assertion.value (/node_modules/should/cjs/should.js:356:9)
      at Context.<anonymous> (/ti.ui.clipboard.test.js:113:42)
      at Test.Runnable.run (/ti-mocha.js:6535:54163)
      at Runner.runTest (/ti-mocha.js:6535:58604)
      at /ti-mocha.js:6535:59445
      at next (/ti-mocha.js:6535:58013)
      at /ti-mocha.js:6535:57975
      at next (/ti-mocha.js:6535:57665)
      at /ti-mocha.js:6535:57759
android.emulator.Titanium.UI.Clipboard.methods#clearText() makes hasText() return false after being called (11)0.006
Error: expected false to be true
at Assertion.fail (/node_modules/should/cjs/should.js:275:13)
      at Assertion.value (/node_modules/should/cjs/should.js:356:9)
      at Context.<anonymous> (/ti.ui.clipboard.test.js:83:42)
      at Test.Runnable.run (/ti-mocha.js:6535:54163)
      at Runner.runTest (/ti-mocha.js:6535:58604)
      at /ti-mocha.js:6535:59445
      at next (/ti-mocha.js:6535:58013)
      at /ti-mocha.js:6535:57975
      at next (/ti-mocha.js:6535:57665)
      at /ti-mocha.js:6535:57759
android.emulator.Titanium.UI.Clipboard.methods#clearData() clears 'text' data type (11)0.009
Error: expected false to be true
at Assertion.fail (/node_modules/should/cjs/should.js:275:13)
      at Assertion.value (/node_modules/should/cjs/should.js:356:9)
      at Context.<anonymous> (/ti.ui.clipboard.test.js:59:42)
      at Test.Runnable.run (/ti-mocha.js:6535:54163)
      at Runner.runTest (/ti-mocha.js:6535:58604)
      at /ti-mocha.js:6535:59445
      at next (/ti-mocha.js:6535:58013)
      at /ti-mocha.js:6535:57975
      at next (/ti-mocha.js:6535:57665)
      at /ti-mocha.js:6535:57759
android.emulator.Titanium.UI.Clipboard.examplesCopy Text to the Clipboard (11)0.004
Error: expected null to equal ''
at Assertion.fail (/node_modules/should/cjs/should.js:275:13)
      at Assertion.value (/node_modules/should/cjs/should.js:356:9)
      at Context.<anonymous> (/ti.ui.clipboard.test.js:455:35)
      at Test.Runnable.run (/ti-mocha.js:6535:54163)
      at Runner.runTest (/ti-mocha.js:6535:58604)
      at /ti-mocha.js:6535:59445
      at next (/ti-mocha.js:6535:58013)
      at /ti-mocha.js:6535:57975
      at next (/ti-mocha.js:6535:57665)
      at /ti-mocha.js:6535:57759
android.emulator.Titanium.UI.WebViewblacklistedURLs (11)36.027
Error: timeout of 30000ms exceeded
at Titanium.<anonymous> (/ti-mocha.js:6535:53723)
ios.macos.Titanium.Platform.properties.netmask matches IP address format if defined (10.15.5)0.001
Error: expected undefined to match /\d+\.\d+\.\d+\.\d+/
fail@file:///Users/build/jenkins/workspace/ium-sdk_titanium_mobile_PR-12339/tmp/mocha/build/iphone/build/Products/Debug-maccatalyst/mocha.app/Contents/Resources/node_modules/should/cjs/should.js:275:23
value@file:///Users/build/jenkins/workspace/ium-sdk_titanium_mobile_PR-12339/tmp/mocha/build/iphone/build/Products/Debug-maccatalyst/mocha.app/Contents/Resources/node_modules/should/cjs/should.js:356:23
file:///Users/build/jenkins/workspace/ium-sdk_titanium_mobile_PR-12339/tmp/mocha/build/iphone/build/Products/Debug-maccatalyst/mocha.app/Contents/Resources/ti.platform.test.js:186:42
file:///Users/build/jenkins/workspace/ium-sdk_titanium_mobile_PR-12339/tmp/mocha/build/iphone/build/Products/Debug-maccatalyst/mocha.app/Contents/Resources/ti-mocha.js:4376:41
file:///Users/build/jenkins/workspace/ium-sdk_titanium_mobile_PR-12339/tmp/mocha/build/iphone/build/Products/Debug-maccatalyst/mocha.app/Contents/Resources/ti-mocha.js:4763:17
file:///Users/build/jenkins/workspace/ium-sdk_titanium_mobile_PR-12339/tmp/mocha/build/iphone/build/Products/Debug-maccatalyst/mocha.app/Contents/Resources/ti-mocha.js:4840:23
next@file:///Users/build/jenkins/workspace/ium-sdk_titanium_mobile_PR-12339/tmp/mocha/build/iphone/build/Products/Debug-maccatalyst/mocha.app/Contents/Resources/ti-mocha.js:4688:20
file:///Users/build/jenkins/workspace/ium-sdk_titanium_mobile_PR-12339/tmp/mocha/build/iphone/build/Products/Debug-maccatalyst/mocha.app/Contents/Resources/ti-mocha.js:4698:15
next@file:///Users/build/jenkins/workspace/ium-sdk_titanium_mobile_PR-12339/tmp/mocha/build/iphone/build/Products/Debug-maccatalyst/mocha.app/Contents/Resources/ti-mocha.js:4636:30
file:///Users/build/jenkins/workspace/ium-sdk_titanium_mobile_PR-12339/tmp/mocha/build/iphone/build/Products/Debug-maccatalyst/mocha.app/Contents/Resources/ti-mocha.js:4665:13
timeslice@file:///Users/build/jenkins/workspace/ium-sdk_titanium_mobile_PR-12339/tmp/mocha/build/iphone/build/Products/Debug-maccatalyst/mocha.app/Contents/Resources/ti-mocha.js:5764:29
ios.macos.Titanium.Platform.properties.netmask is a String (10.15.5)0.001
Error: expected undefined to be a string
    expected undefined to have type string
        expected 'undefined' to be 'string'
fail@file:///Users/build/jenkins/workspace/ium-sdk_titanium_mobile_PR-12339/tmp/mocha/build/iphone/build/Products/Debug-maccatalyst/mocha.app/Contents/Resources/node_modules/should/cjs/should.js:275:23
value@file:///Users/build/jenkins/workspace/ium-sdk_titanium_mobile_PR-12339/tmp/mocha/build/iphone/build/Products/Debug-maccatalyst/mocha.app/Contents/Resources/node_modules/should/cjs/should.js:356:23
file:///Users/build/jenkins/workspace/ium-sdk_titanium_mobile_PR-12339/tmp/mocha/build/iphone/build/Products/Debug-maccatalyst/mocha.app/Contents/Resources/ti.platform.test.js:178:81
file:///Users/build/jenkins/workspace/ium-sdk_titanium_mobile_PR-12339/tmp/mocha/build/iphone/build/Products/Debug-maccatalyst/mocha.app/Contents/Resources/ti-mocha.js:4376:41
file:///Users/build/jenkins/workspace/ium-sdk_titanium_mobile_PR-12339/tmp/mocha/build/iphone/build/Products/Debug-maccatalyst/mocha.app/Contents/Resources/ti-mocha.js:4763:17
file:///Users/build/jenkins/workspace/ium-sdk_titanium_mobile_PR-12339/tmp/mocha/build/iphone/build/Products/Debug-maccatalyst/mocha.app/Contents/Resources/ti-mocha.js:4840:23
next@file:///Users/build/jenkins/workspace/ium-sdk_titanium_mobile_PR-12339/tmp/mocha/build/iphone/build/Products/Debug-maccatalyst/mocha.app/Contents/Resources/ti-mocha.js:4688:20
file:///Users/build/jenkins/workspace/ium-sdk_titanium_mobile_PR-12339/tmp/mocha/build/iphone/build/Products/Debug-maccatalyst/mocha.app/Contents/Resources/ti-mocha.js:4698:15
next@file:///Users/build/jenkins/workspace/ium-sdk_titanium_mobile_PR-12339/tmp/mocha/build/iphone/build/Products/Debug-maccatalyst/mocha.app/Contents/Resources/ti-mocha.js:4636:30
file:///Users/build/jenkins/workspace/ium-sdk_titanium_mobile_PR-12339/tmp/mocha/build/iphone/build/Products/Debug-maccatalyst/mocha.app/Contents/Resources/ti-mocha.js:4665:13
timeslice@file:///Users/build/jenkins/workspace/ium-sdk_titanium_mobile_PR-12339/tmp/mocha/build/iphone/build/Products/Debug-maccatalyst/mocha.app/Contents/Resources/ti-mocha.js:5764:29
ios.macos.Titanium.Platform.properties.address matches IP address format if defined (10.15.5)0.001
Error: expected undefined to match /\d+\.\d+\.\d+\.\d+/
fail@file:///Users/build/jenkins/workspace/ium-sdk_titanium_mobile_PR-12339/tmp/mocha/build/iphone/build/Products/Debug-maccatalyst/mocha.app/Contents/Resources/node_modules/should/cjs/should.js:275:23
value@file:///Users/build/jenkins/workspace/ium-sdk_titanium_mobile_PR-12339/tmp/mocha/build/iphone/build/Products/Debug-maccatalyst/mocha.app/Contents/Resources/node_modules/should/cjs/should.js:356:23
file:///Users/build/jenkins/workspace/ium-sdk_titanium_mobile_PR-12339/tmp/mocha/build/iphone/build/Products/Debug-maccatalyst/mocha.app/Contents/Resources/ti.platform.test.js:32:42
file:///Users/build/jenkins/workspace/ium-sdk_titanium_mobile_PR-12339/tmp/mocha/build/iphone/build/Products/Debug-maccatalyst/mocha.app/Contents/Resources/ti-mocha.js:4376:41
file:///Users/build/jenkins/workspace/ium-sdk_titanium_mobile_PR-12339/tmp/mocha/build/iphone/build/Products/Debug-maccatalyst/mocha.app/Contents/Resources/ti-mocha.js:4763:17
file:///Users/build/jenkins/workspace/ium-sdk_titanium_mobile_PR-12339/tmp/mocha/build/iphone/build/Products/Debug-maccatalyst/mocha.app/Contents/Resources/ti-mocha.js:4840:23
next@file:///Users/build/jenkins/workspace/ium-sdk_titanium_mobile_PR-12339/tmp/mocha/build/iphone/build/Products/Debug-maccatalyst/mocha.app/Contents/Resources/ti-mocha.js:4688:20
file:///Users/build/jenkins/workspace/ium-sdk_titanium_mobile_PR-12339/tmp/mocha/build/iphone/build/Products/Debug-maccatalyst/mocha.app/Contents/Resources/ti-mocha.js:4698:15
next@file:///Users/build/jenkins/workspace/ium-sdk_titanium_mobile_PR-12339/tmp/mocha/build/iphone/build/Products/Debug-maccatalyst/mocha.app/Contents/Resources/ti-mocha.js:4636:30
file:///Users/build/jenkins/workspace/ium-sdk_titanium_mobile_PR-12339/tmp/mocha/build/iphone/build/Products/Debug-maccatalyst/mocha.app/Contents/Resources/ti-mocha.js:4665:13
timeslice@file:///Users/build/jenkins/workspace/ium-sdk_titanium_mobile_PR-12339/tmp/mocha/build/iphone/build/Products/Debug-maccatalyst/mocha.app/Contents/Resources/ti-mocha.js:5764:29
ios.macos.Titanium.Platform.properties.address is a String (10.15.5)0
Error: expected undefined to be a string
    expected undefined to have type string
        expected 'undefined' to be 'string'
fail@file:///Users/build/jenkins/workspace/ium-sdk_titanium_mobile_PR-12339/tmp/mocha/build/iphone/build/Products/Debug-maccatalyst/mocha.app/Contents/Resources/node_modules/should/cjs/should.js:275:23
value@file:///Users/build/jenkins/workspace/ium-sdk_titanium_mobile_PR-12339/tmp/mocha/build/iphone/build/Products/Debug-maccatalyst/mocha.app/Contents/Resources/node_modules/should/cjs/should.js:356:23
file:///Users/build/jenkins/workspace/ium-sdk_titanium_mobile_PR-12339/tmp/mocha/build/iphone/build/Products/Debug-maccatalyst/mocha.app/Contents/Resources/ti.platform.test.js:24:81
file:///Users/build/jenkins/workspace/ium-sdk_titanium_mobile_PR-12339/tmp/mocha/build/iphone/build/Products/Debug-maccatalyst/mocha.app/Contents/Resources/ti-mocha.js:4376:41
file:///Users/build/jenkins/workspace/ium-sdk_titanium_mobile_PR-12339/tmp/mocha/build/iphone/build/Products/Debug-maccatalyst/mocha.app/Contents/Resources/ti-mocha.js:4763:17
file:///Users/build/jenkins/workspace/ium-sdk_titanium_mobile_PR-12339/tmp/mocha/build/iphone/build/Products/Debug-maccatalyst/mocha.app/Contents/Resources/ti-mocha.js:4840:23
next@file:///Users/build/jenkins/workspace/ium-sdk_titanium_mobile_PR-12339/tmp/mocha/build/iphone/build/Products/Debug-maccatalyst/mocha.app/Contents/Resources/ti-mocha.js:4688:20
file:///Users/build/jenkins/workspace/ium-sdk_titanium_mobile_PR-12339/tmp/mocha/build/iphone/build/Products/Debug-maccatalyst/mocha.app/Contents/Resources/ti-mocha.js:4698:15
next@file:///Users/build/jenkins/workspace/ium-sdk_titanium_mobile_PR-12339/tmp/mocha/build/iphone/build/Products/Debug-maccatalyst/mocha.app/Contents/Resources/ti-mocha.js:4636:30
file:///Users/build/jenkins/workspace/ium-sdk_titanium_mobile_PR-12339/tmp/mocha/build/iphone/build/Products/Debug-maccatalyst/mocha.app/Contents/Resources/ti-mocha.js:4665:13
timeslice@file:///Users/build/jenkins/workspace/ium-sdk_titanium_mobile_PR-12339/tmp/mocha/build/iphone/build/Products/Debug-maccatalyst/mocha.app/Contents/Resources/ti-mocha.js:5764:29

Generated by 🚫 dangerJS against b40d2af

sgtcoolguy
sgtcoolguy approved these changes Dec 14, 2020
View reviewed changes
Copy link
Contributor

@sgtcoolguy sgtcoolguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ssekhri
Copy link

ssekhri commented Dec 15, 2020

FR Passed.
Mac OS: 10.15.4
SDK: 10.0.0.v20201211130804
Appc CLI: 8.1.1
JDK: 11.0.6
Node: 12.16.1
Studio: 6.0.0.202005141803
Xcode: 12.0.1
iPhone 7Plus(v14.2), iPhone X(v13.6.1)

@sgtcoolguy sgtcoolguy merged commit 798bd54 into tidev:master Dec 16, 2020
@build
Copy link
Contributor

build commented Dec 16, 2020

The backport to 9_3_X failed:

The process 'git' failed with exit code 128

Check the run for full details
To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Check out the target branch
git checkout 9_3_X
# Make sure it's up to date
git pull
# Check out your branch
git checkout -b backport-12339-to-9_3_X
# Apply the commits from the PR
curl -s https://github.com/appcelerator/titanium_mobile/commit/3ba4fdb92027221dfdb5bdeab90c114250f0642c.patch | git am -3 --ignore-whitespace
curl -s https://github.com/appcelerator/titanium_mobile/commit/380f7329b762efd26cf618d8f66c327041123300.patch | git am -3 --ignore-whitespace
# Push it to GitHub
git push --set-upstream origin backport-12339-to-9_3_X

Then, create a pull request where the base branch is 9_3_X and the compare/head branch is backport-12339-to-9_3_X.

sgtcoolguy pushed a commit that referenced this pull request Dec 16, 2020
@vijaysingh-axway @sgtcoolguy
fix(ios): removing eventlistener multiple times ourCallbackCount shou…
ab9997b 
…ld not be in negative value (#12339)

Fixes TIMOB-28267
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgtcoolguy sgtcoolguy sgtcoolguy approved these changes

Assignees
No one assigned
Labels
bug in-qe-testing 🕵 ios
Projects
None yet
Milestone
10.0.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@vijaysingh-axway @build @ssekhri @sgtcoolguy @ewanharris