Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ios): add workspace workaround #12354

Merged
merged 3 commits into from Jan 5, 2021
Merged

Conversation

hansemannn
Copy link
Collaborator

@hansemannn hansemannn commented Dec 19, 2020

… until all external SDK dependencies in modules are built

Important: There should also be a note about this in the release notes, because native app extensions will also need to specify this setting in their build settings.

JIRA: https://jira.appcelerator.org/browse/TIMOB-28303

… until all external SDK dependencies in modules are built
@build build added this to the 10.0.0 milestone Dec 19, 2020
@build
Copy link
Contributor

build commented Dec 19, 2020

Messages
📖 🎉 Another contribution from our awesome community member, hansemannn! Thanks again for helping us make Titanium SDK better. 👍
📖 ✊ The commits in this PR match our conventions! Feel free to Rebase and Merge this PR when ready.
📖

✅ All tests are passing
Nice one! All 10267 tests are passing.
(There are 658 skipped tests not included in that total)

Generated by 🚫 dangerJS against c43fd02

@jasonkneen
Copy link
Sponsor Contributor

Can we can this validated and merged? This is a MAJOR breaking issue on Xcode 12.3 on certain projects that means we can't fully upgrade to 12.3 without patching our SDKs.

URGENT!

Copy link
Contributor

@sgtcoolguy sgtcoolguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@vijaysingh-axway vijaysingh-axway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR passed.

@ssekhri
Copy link

ssekhri commented Jan 5, 2021

FR Passed.
Verified on:
Mac OS: 10.15.4
SDK: 10.0.0.v20210104110722
Appc CLI: 8.1.1
JDK: 11.0.6
Node: 12.16.1
Studio: 6.0.0.202005141803
Xcode: 12.3, 12.2
iOS simulator 14.3, 13.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants