New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
macOS Ti.Blob/Image scale incorrect #12445
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
sgtcoolguy
force-pushed
the
macos-scale
branch
from
February 5, 2021 15:46
f642ed9
to
9ca256e
Compare
Didn't find any reliable way to detect and "fix" this issue. Sometimes macOS catalyst apps (maybe only on Catalina) simply return a view's bounds/size in its that assume 2x density while the screen/device itself reports a 1x density. So ultimately when we render the view to image the image is half the size it should be. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Optional Description:
This is a work in progress to try and debug why sometimes macOS image blobs report bad/unexpected width/height values for rendered View images.
I suspect this relates to the known issues around macOS Catalyst apps
nativeScale
being incorrect sometimes on Catalina (54009624): https://developer.apple.com/documentation/macos-release-notes/macos-catalina-10_15-release-notesI cannot find a reliable way to detect when this occurs to hack a fix for it. The various scale values all report the correct value in the same code where the view reports a 2x density equivalent
CGRect
size (i.e. 5.5 for an 11px width). I also strongly suspect it may have something to do with then the OS has a modal dialog and/or notifications open. Once I close them all, the issue didn't seem to re-occur.So, to sum up: