Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timob 7220 TableViewRow implementation. #1246

Merged
merged 14 commits into from Jan 26, 2012
Merged

Timob 7220 TableViewRow implementation. #1246

merged 14 commits into from Jan 26, 2012

Conversation

nebrius
Copy link
Contributor

@nebrius nebrius commented Jan 24, 2012

No description provided.

@arthurevans
Copy link
Contributor

Reviewing doc.

On Mobile Web, the `top` value is interpreted as a pixel offset between the top of the top
row of data and the top of the table view. So a `top` value of 0 scrolls the list to
the top. A positive value scrolls it down. Values outside the scrollable range are clipped
so that negative numbers scrolls the list to the top, and large positive values scrolls the
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both instances of "scrolls" on this line should be "scroll".

@arthurevans
Copy link
Contributor

Reviewed. Aside from trivial copyedit, looks good.

@@ -41,6 +41,7 @@ def ignore(file):
return False

def generate_jsca():
return ''
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to remove this line. :)

cb1kenobi added a commit that referenced this pull request Jan 26, 2012
Timob 7220 TableViewRow implementation.
@cb1kenobi cb1kenobi merged commit 2ec1339 into tidev:master Jan 26, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants