Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ios): videoplayer crash when setting showsControls earlier than url property #12508

Merged
merged 4 commits into from Apr 8, 2021

Conversation

vijaysingh-axway
Copy link
Contributor

@build build added this to the 10.1.0 milestone Mar 1, 2021
@build build requested a review from a team March 1, 2021 21:20
@build
Copy link
Contributor

build commented Mar 1, 2021

Fails
🚫 Tests have failed, see below for more information.
Warnings
⚠️ This PR has milestone set to 10.0.0, but the version defined in package.json is 10.1.0 Please either: - Update the milestone on the PR - Update the version in package.json - Hold the PR to be merged later after a release and version bump on this branch
Messages
📖 ✊ The commits in this PR match our conventions! Feel free to Rebase and Merge this PR when ready.
📖 ❌ 3 tests have failed There are 3 tests failing and 974 skipped out of 16676 total tests.
📖

💾 Here's the generated SDK zipfile.

Tests:

ClassnameNameTimeError
android.emulator.Titanium.Network.HTTPClientcallbackTestForGETMethod (5.0.2)60.004
Error: Timeout of 60000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves. (app.js)
android.emulator.Titanium.UI.View"after all" hook for "rgba fallback" (5.0.2)20.558
Error: Timeout of 10000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves. (app.js)
android.emulator.Titanium.UI.View"after each" hook for "getOrCreateView() should always return a View" (5.0.2)10.502
Error: Timeout of 10000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves. (app.js)

Generated by 🚫 dangerJS against b804b0f

@vijaysingh-axway vijaysingh-axway added backport 10_2_X when applied, PRs with this label will get an auto-generated backport to 10_2_X branch on merge bug labels Mar 18, 2021
@vijaysingh-axway vijaysingh-axway modified the milestones: 10.1.0, 10.0.0 Mar 18, 2021
Copy link
Contributor

@ssjsamir ssjsamir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FR Passed using the test case from: https://jira.appcelerator.org/browse/TIMOB-28217

Test Environment

MacOS Big Sur: 11.1 Beta 1
Xcode: 12.2 Beta
Java Version: 1.8.0_242
Android NDK: 21.3.6528147
Node.js: 12.18.1
""NPM":"5.0.0","CLI":"8.1.1""
iphone 8 14.4 Sim

@sgtcoolguy sgtcoolguy merged commit fe3dedd into tidev:master Apr 8, 2021
@build build removed the backport 10_2_X when applied, PRs with this label will get an auto-generated backport to 10_2_X branch on merge label Apr 8, 2021
sgtcoolguy pushed a commit to sgtcoolguy/titanium_mobile that referenced this pull request Apr 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants