New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add Ti.UI.OptionBar #12510
feat: add Ti.UI.OptionBar #12510
Conversation
Fixes TIMOB-28317
Tests:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CR: PASS
NOTE: Maybe we could add snapshot tests for this?
I'm worried that the layout will be slightly different based on system font and DPI. |
FR Passed. |
The backport to
Check the run for full details # Fetch latest updates from GitHub
git fetch
# Check out the target branch
git checkout 10_0_X
# Make sure it's up to date
git pull
# Check out your branch
git checkout -b backport-12510-to-10_0_X
# Apply the commits from the PR
curl -s https://github.com/appcelerator/titanium_mobile/commit/9e9ab37a368848be475007b02f5fb6358b464d6e.patch | git am -3 --ignore-whitespace
# Push it to GitHub
git push --set-upstream origin backport-12510-to-10_0_X Then, create a pull request where the |
JIRA:
https://jira.appcelerator.org/browse/TIMOB-28317
Summary:
layout
property can be set to"horiztonal"
(the default) or"vertical"
.Examples:
Test:
OptionBarTest.js
as yourapp.js
from TIMOB-28317.@@@ button click index: 1
// layout: "vertical",
lines in all 3 spots of the code.