New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(ios): change Ti.UI.TabbedBar to use UITabBar #12511
Conversation
Fixes TIMOB-28373
Tests:
|
Please reconsider if this is really a good idea. The UITabBar is a top-level element on iOS and should not be added to a view directly. It's probably even causing App Store rejections and can be easily overseen by developers that have larger apps and upgrade to SDK 10 (which, in terms of the recent news) will not really help developers. |
|
@vijaysingh-axway Regarding
As well as the fact that button-only tabbed bars (which is the only default right now) will cause major display issues, because UITab's are meant to have an icon and without it, the title will be displayed at the bottom (see screenshot above). |
No one here is suggesting that If you feel this is controversial, then I can close this PR for 10.0.0. This means iOS will use a native On Android, |
JIRA:
https://jira.appcelerator.org/browse/TIMOB-28373
Summary:
Ti.UI.TabbedBar
to use a tab bar instead of a segmented control.Ti.UI.OptionBar
is now used to display a segmented control on iOS. See: TIMOB-28317TabbedBar
should show tabs, like it does on Android, and allow app devs to layout their own tab group like user interface.Test:
TabbedBarTest.js
attached to TIMOB-28373 on iOS.@@@ button click index: 1