Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: disable analytics in templates #12517

Closed
wants to merge 8 commits into from
Closed

chore: disable analytics in templates #12517

wants to merge 8 commits into from

Conversation

m1ga
Copy link
Contributor

@m1ga m1ga commented Mar 3, 2021 •
edited

JIRA: https://jira.appcelerator.org/browse/AC-6719

Optional Description:

Guess it can be removed sooner or later but disabling it already helps when creating a new project 😄

@build build added this to the 10.1.0 milestone Mar 3, 2021
@build
Copy link
Contributor

build commented Mar 3, 2021 •
edited

Warnings
⚠️

Commit a4e5f4dce3826be8aad8b7732523575004d16d75 has a message "Update tiapp.xml" giving 2 errors:

  • subject may not be empty
  • type may not be empty
⚠️

Commit 7550cadfb33fa769fd95aeadc30852ddedf0638f has a message "Update tiapp.xml" giving 2 errors:

  • subject may not be empty
  • type may not be empty
⚠️

Commit 7d05fa793ec575fd1784289d25943f3bfd7db60a has a message "Update tiapp.xml" giving 2 errors:

  • subject may not be empty
  • type may not be empty
⚠️ Tests have failed, see below for more information.
⚠️ This PR has milestone set to 10.1.0, but the version defined in package.json is 10.2.0 Please either: - Update the milestone on the PR - Update the version in package.json - Hold the PR to be merged later after a release and version bump on this branch
Messages
📖

🚨 This PR has one or more commits with warnings/errors for commit messages not matching our configuration. You may want to squash merge this PR and edit the message to match our conventions, or ask the original developer to modify their history.
📖 ❌ 13 tests have failed There are 13 tests failing and 1162 skipped out of 21605 total tests.
📖 🎉 Another contribution from our awesome community member, m1ga! Thanks again for helping us make Titanium SDK better. 👍
📖

💾 Here's the generated SDK zipfile.

Tests:

ClassnameNameTimeError
android.emulator.5.0.Titanium.Analytics.properties.optedOut can be assigned a Boolean value (5.0.2)0.001
Error: Attempt to invoke interface method 'android.content.SharedPreferences$Editor android.content.SharedPreferences.edit()' on a null object reference
at Context.<anonymous> (/ti.analytics.test.js:50:22)
      at CallbackWithArgs.run (<embedded>:6798:17)
android.emulator.5.0.Titanium.Analytics.properties.optedOut defaults to false (5.0.2)0.001
Error: Attempt to invoke interface method 'boolean android.content.SharedPreferences.getBoolean(java.lang.String, boolean)' on a null object reference
at Context.<anonymous> (/ti.analytics.test.js:46:21)
      at CallbackWithArgs.run (<embedded>:6798:17)
android.emulator.5.0.Titanium.Analytics.properties.optedOut is a Boolean (5.0.2)0.003
Error: Attempt to invoke interface method 'boolean android.content.SharedPreferences.getBoolean(java.lang.String, boolean)' on a null object reference
at Assertion.<anonymous> (/node_modules/should/cjs/should.js:2133:18)
      at Assertion.value [as property] (/node_modules/should/cjs/should.js:337:6)
      at Context.<anonymous> (/ti.analytics.test.js:42:29)
android.emulator.5.0.Titanium.Analytics.methods#featureEvent() validate limitations (5.0.2)0.004
Error: expected -2 to equal -1
at Assertion.fail (/node_modules/should/cjs/should.js:275:13)
      at Assertion.value (/node_modules/should/cjs/should.js:356:9)
      at Context.<anonymous> (/ti.analytics.test.js:75:53)
android.emulator.5.0.Titanium.App.properties.sessionId is a read-only String (5.0.2)0.003
Error: expected null to be a string
    expected null to have type string
        expected 'object' to be 'string'
at Assertion.fail (/node_modules/should/cjs/should.js:275:13)
      at Assertion.value [as String] (/node_modules/should/cjs/should.js:356:9)
      at Context.<anonymous> (/ti.app.test.js:242:64)
android.emulator.main.Titanium.Analytics.properties.optedOut can be assigned a Boolean value (12)0
Error: Attempt to invoke interface method 'android.content.SharedPreferences$Editor android.content.SharedPreferences.edit()' on a null object reference
at Context.<anonymous> (/ti.analytics.test.js:50:22)
      at CallbackWithArgs.run (<embedded>:6798:17)
android.emulator.main.Titanium.Analytics.properties.optedOut defaults to false (12)0.001
Error: Attempt to invoke interface method 'boolean android.content.SharedPreferences.getBoolean(java.lang.String, boolean)' on a null object reference
at Context.<anonymous> (/ti.analytics.test.js:46:21)
      at CallbackWithArgs.run (<embedded>:6798:17)
android.emulator.main.Titanium.Analytics.properties.optedOut is a Boolean (12)0.005
Error: Attempt to invoke interface method 'boolean android.content.SharedPreferences.getBoolean(java.lang.String, boolean)' on a null object reference
at Assertion.<anonymous> (/node_modules/should/cjs/should.js:2133:18)
      at Assertion.value [as property] (/node_modules/should/cjs/should.js:337:6)
      at Context.<anonymous> (/ti.analytics.test.js:42:29)
android.emulator.main.Titanium.Analytics.methods#featureEvent() validate limitations (12)0.006
Error: expected -2 to equal -1
at Assertion.fail (/node_modules/should/cjs/should.js:275:13)
      at Assertion.value (/node_modules/should/cjs/should.js:356:9)
      at Context.<anonymous> (/ti.analytics.test.js:75:53)
android.emulator.main.Titanium.App.properties.sessionId is a read-only String (12)0.002
Error: expected null to be a string
    expected null to have type string
        expected 'object' to be 'string'
at Assertion.fail (/node_modules/should/cjs/should.js:275:13)
      at Assertion.value [as String] (/node_modules/should/cjs/should.js:356:9)
      at Context.<anonymous> (/ti.app.test.js:242:64)
ios.ipad.Titanium.Analytics.methods#featureEvent() validate limitations (15.0.0)0.001
Error: expected -2 to equal -1
value@file:///Users/build/Library/Developer/CoreSimulator/Devices/3F8CD230-01D6-4BE0-B907-FBD8B6C67971/data/Containers/Bundle/Application/3D122696-F1DB-499F-A950-1DDB9C2352D7/mocha.app/node_modules/should/cjs/should.js:356:23
@file:///Users/build/Library/Developer/CoreSimulator/Devices/3F8CD230-01D6-4BE0-B907-FBD8B6C67971/data/Containers/Bundle/Application/3D122696-F1DB-499F-A950-1DDB9C2352D7/mocha.app/ti.analytics.test.js:75:67
run@file:///Users/build/Library/Developer/CoreSimulator/Devices/3F8CD230-01D6-4BE0-B907-FBD8B6C67971/data/Containers/Bundle/Application/3D122696-F1DB-499F-A950-1DDB9C2352D7/mocha.app/ti.main.js:9415:22
processImmediateQueue@file:///Users/build/Library/Developer/CoreSimulator/Devices/3F8CD230-01D6-4BE0-B907-FBD8B6C67971/data/Containers/Bundle/Application/3D122696-F1DB-499F-A950-1DDB9C2352D7/mocha.app/ti.main.js:9478:18
drainQueues@file:///Users/build/Library/Developer/CoreSimulator/Devices/3F8CD230-01D6-4BE0-B907-FBD8B6C67971/data/Containers/Bundle/Application/3D122696-F1DB-499F-A950-1DDB9C2352D7/mocha.app/ti.main.js:9455:52
ios.iphone.Titanium.Analytics.methods#featureEvent() validate limitations (15.0.0)0.001
Error: expected -2 to equal -1
value@file:///Users/build/Library/Developer/CoreSimulator/Devices/660D6F4E-5EDF-42BD-8AFB-FC202C766364/data/Containers/Bundle/Application/7455B37F-290A-45EA-A25C-3B2D3535B1A1/mocha.app/node_modules/should/cjs/should.js:356:23
@file:///Users/build/Library/Developer/CoreSimulator/Devices/660D6F4E-5EDF-42BD-8AFB-FC202C766364/data/Containers/Bundle/Application/7455B37F-290A-45EA-A25C-3B2D3535B1A1/mocha.app/ti.analytics.test.js:75:67
run@file:///Users/build/Library/Developer/CoreSimulator/Devices/660D6F4E-5EDF-42BD-8AFB-FC202C766364/data/Containers/Bundle/Application/7455B37F-290A-45EA-A25C-3B2D3535B1A1/mocha.app/ti.main.js:9415:22
processImmediateQueue@file:///Users/build/Library/Developer/CoreSimulator/Devices/660D6F4E-5EDF-42BD-8AFB-FC202C766364/data/Containers/Bundle/Application/7455B37F-290A-45EA-A25C-3B2D3535B1A1/mocha.app/ti.main.js:9478:18
drainQueues@file:///Users/build/Library/Developer/CoreSimulator/Devices/660D6F4E-5EDF-42BD-8AFB-FC202C766364/data/Containers/Bundle/Application/7455B37F-290A-45EA-A25C-3B2D3535B1A1/mocha.app/ti.main.js:9455:52
ios.macos.Titanium.Analytics.methods#featureEvent() validate limitations (11.5.2)0.002
Error: expected -2 to equal -1
value@file:///Users/build/jenkins/workspace/ium-sdk_titanium_mobile_PR-12517/tmp/mocha/build/iphone/build/Products/Debug-maccatalyst/mocha.app/Contents/Resources/node_modules/should/cjs/should.js:356:23
file:///Users/build/jenkins/workspace/ium-sdk_titanium_mobile_PR-12517/tmp/mocha/build/iphone/build/Products/Debug-maccatalyst/mocha.app/Contents/Resources/ti.analytics.test.js:75:67
run@file:///Users/build/jenkins/workspace/ium-sdk_titanium_mobile_PR-12517/tmp/mocha/build/iphone/build/Products/Debug-maccatalyst/mocha.app/Contents/Resources/ti.main.js:9415:22
processImmediateQueue@file:///Users/build/jenkins/workspace/ium-sdk_titanium_mobile_PR-12517/tmp/mocha/build/iphone/build/Products/Debug-maccatalyst/mocha.app/Contents/Resources/ti.main.js:9478:18
drainQueues@file:///Users/build/jenkins/workspace/ium-sdk_titanium_mobile_PR-12517/tmp/mocha/build/iphone/build/Products/Debug-maccatalyst/mocha.app/Contents/Resources/ti.main.js:9455:52

Generated by 🚫 dangerJS against 8b1f23e

@m1ga
Copy link
Contributor Author

m1ga commented Sep 14, 2021

added the JIRA ticket. Maybe it can be merged in 10.1.0 so there is one less setting to change when creating a new project 😉

@ewanharris
Copy link
Collaborator

@m1ga, we might look to include this in 10.1.1 or 10.2.0 as we're within 6 months or so of the EoS date.

@m1ga
Copy link
Contributor Author

m1ga commented Sep 14, 2021

no rush! Just wanted to include the last missing details

@m1ga
Copy link
Contributor Author

m1ga commented Mar 18, 2022

closing in favor of #13316

@m1ga m1ga closed this Mar 18, 2022
@m1ga m1ga deleted the disableAnalytics branch December 10, 2022 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
community 🔥
Projects
None yet
Milestone
10.1.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@m1ga @build @ewanharris @jquick-axway