Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(deps-dev): update titanium-docgen to 4.10.3 #12534

Merged
merged 2 commits into from Mar 9, 2021
Merged

chore(deps-dev): update titanium-docgen to 4.10.3 #12534

merged 2 commits into from Mar 9, 2021

Conversation

sgtcoolguy
Copy link
Contributor

Relates to #12525

Update titanium-docgen to version that produces JSCA file without accessors or pretty printing - significantly reducing file size (though it is still large!)

@sgtcoolguy sgtcoolguy added the docs label Mar 9, 2021
@build build added this to the 10.1.0 milestone Mar 9, 2021
@build
Copy link
Contributor

build commented Mar 9, 2021 •
edited

Fails
🚫

Test suite crashed on iOS simulator. Please see the crash log for more details.
Warnings
⚠️ There is no linked JIRA ticket in the PR body. Please include the URL of the relevant JIRA ticket. If you need to, you may file a ticket on JIRA
Messages
📖 ✊ The commits in this PR match our conventions! Feel free to Rebase and Merge this PR when ready.
📖

✅ All tests are passing
Nice one! All 7725 tests are passing.
(There are 511 skipped tests not included in that total)

Generated by 🚫 dangerJS against b55239d

@sgtcoolguy sgtcoolguy changed the title chore(deps-dev): update titanium-docgen to 4.10.2 chore(deps-dev): update titanium-docgen to 4.10.3 Mar 9, 2021
ewanharris
ewanharris approved these changes Mar 9, 2021
View reviewed changes
Copy link
Collaborator

@ewanharris ewanharris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ewanharris ewanharris merged commit 09b9f2c into tidev:master Mar 9, 2021
@sgtcoolguy sgtcoolguy deleted the titanium-docgen-4.10.2 branch March 9, 2021 22:48
@sgtcoolguy sgtcoolguy added the backport 10_2_X when applied, PRs with this label will get an auto-generated backport to 10_2_X branch on merge label Mar 9, 2021
@build build mentioned this pull request Mar 9, 2021
Merged
@build build removed the backport 10_2_X when applied, PRs with this label will get an auto-generated backport to 10_2_X branch on merge label Mar 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ewanharris ewanharris ewanharris approved these changes

Assignees
No one assigned
Labels
docs
Projects
None yet
Milestone
10.1.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sgtcoolguy @build @ewanharris