New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(android): material theme/widget improvements #12537
Conversation
Tests:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CR: PASS
if (hasCustomBackground) { | ||
btn = new AppCompatButton(proxy.getActivity()) { | ||
@Override | ||
public boolean onFilterTouchEventForSecurity(MotionEvent event) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Potential to move this out and remove duplicate code?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought about it, but the duplicated code was so small that I didn't think it was worth it. Especially since it would bloat it to the below. 🙄
public boolean onFilterTouchEventForSecurity(MotionEvent event)
{
boolean isTouchAllowed = super.onFilterTouchEventForSecurity(event);
return handleFilterTouchEventForSecurity(isTouchAllowed, event);
}
private boolean handleFilterTouchEventForSecurity(boolean isAllowed, MotionEvent event)
{
if (!isAllowed) {
fireSyncEvent(TiC.EVENT_TOUCH_FILTERED, dictFromEvent(event));
}
return isAllowed;
}
FR Passed. |
The backport to
Check the run for full details # Fetch latest updates from GitHub
git fetch
# Check out the target branch
git checkout 10_0_X
# Make sure it's up to date
git pull
# Check out your branch
git checkout -b backport-12537-to-10_0_X
# Apply the commits from the PR
curl -s https://github.com/appcelerator/titanium_mobile/commit/2b34433a34513b4bf0bf6cfd65b3a9ba879c8ebc.patch | git am -3 --ignore-whitespace
curl -s https://github.com/appcelerator/titanium_mobile/commit/8da43e7ae1df50bac37b9dfb781d6ba71f330193.patch | git am -3 --ignore-whitespace
curl -s https://github.com/appcelerator/titanium_mobile/commit/8858e79cd0ebaa911a7ea5ca7eec74b876f7a740.patch | git am -3 --ignore-whitespace
curl -s https://github.com/appcelerator/titanium_mobile/commit/35a656e06353a293364ebcc94a79796ff289c70f.patch | git am -3 --ignore-whitespace
curl -s https://github.com/appcelerator/titanium_mobile/commit/216fff45e5a362c77ef5e9974eb7dcb9e75b720f.patch | git am -3 --ignore-whitespace
# Push it to GitHub
git push --set-upstream origin backport-12537-to-10_0_X Then, create a pull request where the |
JIRA:
https://jira.appcelerator.org/browse/TIMOB-28301
Summary:
TabGroup
andTabbedBar
top tab style to scale icons to fit like how bottom style works.Ti.UI.Button
background and touch feedback handling.MaterialButton
we're using since it can cause it to be rendered incorrectly. Will now fallback to usingAppCompatButton
if you override its background.MaterialButton
when not overriding its background.Test:
[WARN] MaterialButton: MaterialButton manages its own background to control elevation, shape, color and states...